Fix SubMesh IsGlobal #12529
Fix SubMesh IsGlobal #12529
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12529/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12529/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12529/merge#BCU1XR#0 |
|
Should it all be on one long line instead? It used to say what the formatting problem/solution was but now I can't find that info anymore, for the last few PRs that had formatting errors... |
You can run The error is also displayed in the logs, though it could be difficult to find. Or you can see it by running |
I used to be able to find what the particular formatting issue was (and on what line), now all I can find out is that there's a formatting error in the file without the needed details to fix it, ever since the build/validation system changed recently I think.... But I'll try running the prettier locally to see if it fixes the issue. Okay I ran the format fixer locally and re-committed, one long line it is then... Thanks! :) |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12529/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12529/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12529/merge#BCU1XR#0 |
Currently IsGlobal returns true if the subMesh has all the vertices of the mesh but it should check if the subMesh also has all the indices of the mesh IMO.
Because otherwise the mesh's full bounding info is returned by getBoundingInfo when the subMesh has all the vertices but only some of the indices of the whole mesh. E.G. the subMeshes created by CreateTiledGround, which shouldn't return the bounding info for the whole mesh but currently are.
Forum discussion w/ test PGs: https://forum.babylonjs.com/t/find-or-define-center-point-of-submesh/30400/3