Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning when using ignored options with Dashed Lines update. #12509

Merged
merged 3 commits into from
May 16, 2022
Merged

Add a warning when using ignored options with Dashed Lines update. #12509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17262a8
Add a warning when using ignored options with Dashed Lines update.
carolhmj May 10, 2022
ef7f762
fix import
carolhmj May 11, 2022
22382ac
swap tools for logger
carolhmj May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dev/core/src/Meshes/Builders/linesBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type { FloatArray, Nullable } from "../../types";
import { LinesMesh } from "../../Meshes/linesMesh";
import type { Scene } from "../../scene";
import { VertexBuffer } from "../../Buffers/buffer";
import { Logger } from "../../Misc/logger";

declare type Material = import("../../Materials/material").Material;

Expand Down Expand Up @@ -302,6 +303,9 @@ export function CreateDashedLines(
p += 3;
}
};
if (options.dashNb || options.dashSize || options.gapSize || options.useVertexAlpha || options.material) {
Logger.Warn("You have used an option other than points with the instance option. Please be aware that these other options will be ignored.");
}
instance.updateMeshPositions(positionFunction, false);
return instance;
}
Expand Down