Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMPRESSED_SRGB_S3TC_DXT1_EXT #12488

Merged
merged 1 commit into from
May 6, 2022

Conversation

kircher1
Copy link
Contributor

@kircher1 kircher1 commented May 6, 2022

If requesting sRGB for an ST3C RGB texture, the previous logic was using an sRGB + ALPHA format. This change will use RGB (no alpha) instead.

If requesting sRGB for an ST3C **RGB** texture, the previous logic was using an RGB + **ALPHA** format. This change will use RGB (no alpha) instead.
@deltakosh deltakosh requested review from Popov72 and bghgary May 6, 2022 00:24
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@deltakosh deltakosh enabled auto-merge (squash) May 6, 2022 00:32
@azure-pipelines
Copy link

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deltakosh deltakosh merged commit eb36034 into BabylonJS:master May 6, 2022
@kircher1 kircher1 deleted the users/briank/srgb-s3tc branch August 26, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants