Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning and checks for noimpostor children #12482

Merged
merged 4 commits into from
May 6, 2022
Merged

warning and checks for noimpostor children #12482

merged 4 commits into from
May 6, 2022

Conversation

CedricGuillemet
Copy link
Contributor

fixes #12446

2 issues :

  • when creating impostor for children mesh, their impostor will effectively be created with the NoImpostor. So shapes are not available and you get the crash. I've added a check and log a warning
  • The correct way to debugdisplay impostor in this case is to do the call on the NoImpostor parent. But you have to provide a 2nd parameter or nothing appears. I've also added a warning in that particular case.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

1 similar comment
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

1 similar comment
@azure-pipelines
Copy link

@deltakosh deltakosh enabled auto-merge (squash) May 5, 2022 18:30
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@deltakosh deltakosh disabled auto-merge May 6, 2022 00:29
@deltakosh deltakosh merged commit 1b7f8b6 into BabylonJS:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to show Mesh Impostors in Cannon/Oimo
3 participants