Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12394 #12395

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix #12394 #12395

merged 1 commit into from
Apr 13, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12395/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12395/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12395/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12395/merge#BCU1XR#0

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12395/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh
Copy link
Contributor Author

deltakosh commented Apr 13, 2022

cc @RaananW
Hoping the error is just a hiccup

@deltakosh deltakosh merged commit 16269c2 into master Apr 13, 2022
@deltakosh deltakosh deleted the fix-12394 branch April 13, 2022 16:51
@RaananW
Copy link
Member

RaananW commented Apr 13, 2022

cc @RaananW
Hoping the error is just a hipcup

Firefox's website was offline... So yes, a hiccup 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants