Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12174 #12391

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fix #12174 #12391

merged 3 commits into from
Apr 13, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh requested a review from bghgary April 12, 2022 20:28
@deltakosh deltakosh added the bug label Apr 12, 2022
@deltakosh
Copy link
Contributor Author

Still need to do it only when required

@deltakosh deltakosh marked this pull request as draft April 12, 2022 20:30
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12391/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12391/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12391/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12391/merge#BCU1XR#0

@deltakosh
Copy link
Contributor Author

Better! Now it is searchable and usable :D

@deltakosh deltakosh marked this pull request as ready for review April 12, 2022 21:27
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12391/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12391/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12391/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12391/merge#BCU1XR#0

@deltakosh deltakosh merged commit e47fb5b into master Apr 13, 2022
@deltakosh deltakosh deleted the FIx-unicode branch April 13, 2022 14:59
@carolhmj carolhmj mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolhmj carolhmj carolhmj approved these changes

@bghgary bghgary Awaiting requested review from bghgary

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltakosh @carolhmj