Fix minor shader compiler issues

[kaliatech]

Changes:

• Allow semicolons in shader single line comments
• Allow indented multiline macros

Related post in forum showing reproduction for the single line comment issue:

• https://forum.babylonjs.com/t/possible-shader-compiler-bug-with-single-line-comments/29182

There are no reports for the indented multiline macro issue, but I verified locally that indenting a multiline macro would break compiler, and with this fix, it works.

[azure-pipelines]

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12369/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12369/merge#BCU1XR#0

[sebavan]

Nice :-)

[azure-pipelines]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

[azure-pipelines]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

[sebavan]

This loooks like a great start but could you merge back master in so that we keep only the issues related to the PBR ? I am seeing some iridescence issues related to master in the build.

[azure-pipelines]

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12369/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12369/merge#BCU1XR#0

[azure-pipelines]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

[azure-pipelines]

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

[kaliatech]

could you merge back master in so that we keep only the issues related to the PBR

I rebased back to master before your recent PR. The tests are still failing and it does seem to be due to changes I made in this PR. Looking at some of the failing test PGs, the underlying reason is not obvious to me though. My guess is that's due to my 2nd commit to allow for multiline macros, but that's just a guess.

If not obvious to anyone else, I will try running/debugging the failing tests next week.

[BlakeOne]

Hey @kaliatech, it seems pushing the trimmed line for the macro line instead of the original line fixes the 3 PG's that were failing validation, although I'm not sure why would be necessary... Like below for example. :)

const trimmedLine = line.trim();
if (trimmedLine[0] === "#") {
    this._lines.push(trimmedLine);
    continue;
}

[kaliatech]

Handling multiline macros got complicated with a few different issues. I removed that commit and so this PR now only addresses the semicolons in the single line comment issue. I'll add more info to the forum post.

[azure-pipelines]

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12369/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12369/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12369/merge#BCU1XR#0