Revert the missing fix and add some logs #12367
Conversation
|
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12367/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12367/merge#BCU1XR#0 |
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Cc @sebavan as it seems the iridescence tests are failing |
Can you try to merge master in ? I do not understand why master is not failing :-( It is like iridescence is not available in your branch but the config is used from master... weird |
|
I updated it to see, still no explanations so far... |
|
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12367/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12367/merge#BCU1XR#0 |
|
@RaananW would be great if you could have a look, I wonder why the config was from master but none of the iridescence code was available ? but at least it is all in :-) |
|
@sebavan - I will look into that. The config is taken from the branch it's in, nothing should be taken from master. |
No description provided.