Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Move the local server to compile using ts-loader #12363

Merged
merged 3 commits into from
Apr 11, 2022
Merged

[Build] Move the local server to compile using ts-loader #12363

merged 3 commits into from
Apr 11, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 8, 2022

Webpack will now compile typescript using ts-loader and will not use the compiled sources from the dist folders of the dev / lts packages.
Note that this might break LTS development, but as this hasn't started yet it is not urgent.

The time it takes to compile is actually the same (might be a little slower this way), but the server won't let you load the resources while compiling.

The server will now wait before reloading the resources while compiling.

Webpack will now compile typescript using ts-loader and will not use the compiled sources from the dist folders of the dev / lts packages.
Note that this might break LTS development, but as this hasn't started yet it is not urgent.

The server will now wait before reloading the resources while compiling.
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12363/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12363/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12363/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12363/merge#BCU1XR#0

@RaananW RaananW merged commit 77d4c73 into BabylonJS:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant