Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NME] Adjust behavior of NME selection to only select a frame if there aren… #12327

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Apr 1, 2022

…'t nodes selected. Also fix an error that showed up on compile.

…'t nodes selected. Also fix an error that showed up on compile.
@carolhmj carolhmj changed the title Adjust behavior of NME selection to only select a frame if there aren… [NME] Adjust behavior of NME selection to only select a frame if there aren… Apr 1, 2022
@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12327/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12327/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12327/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12327/merge#BCU1XR#0

@PatrickRyanMS
Copy link
Member

I tested the functionality and marquee select is working well with nodes in frames. I still think it's worth looking into multi-select for frames either through ctrl + click or marquee selecting frames only. But that can come after this issue as currently there is still a way to move frames one at a time and it does not block functionality like not being able to marquee select nodes in a frame does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants