Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty loadingUIText setter for null engine #12320

Conversation

nekochanoide
Copy link
Contributor

using null engine and setting loading ui text to it causes crash...
added 'do nothing' setter for loadingUIText

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12320/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12320/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12320/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12320/merge#BCU1XR#0

@RaananW
Copy link
Member

RaananW commented Apr 1, 2022

The setter is being inherited from the Engine class, and is located in NullEngine as well. I gues the issue is that loadingScreen is gone?

@nekochanoide
Copy link
Contributor Author

yes. no loadingScreen in null engine but NullEngine type says that it's okey to use loadingUIText, so code in Engine throws 'can't access loadingUIText of undefined'.

@nekochanoide
Copy link
Contributor Author

to break current version execute this

let e = new BABYLON.NullEngine();
e.loadingUIText = "hello";

@deltakosh deltakosh enabled auto-merge (squash) April 1, 2022 15:28
@deltakosh deltakosh disabled auto-merge April 1, 2022 15:34
@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@deltakosh deltakosh merged commit 48e2dda into BabylonJS:master Apr 1, 2022
@nekochanoide nekochanoide deleted the fix/null-engine-missing-loading-ui-text branch April 2, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants