Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] revamp declarations #12319

Merged
merged 6 commits into from
Apr 1, 2022
Merged

[Build] revamp declarations #12319

merged 6 commits into from
Apr 1, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 1, 2022

Making declaration build a bit more future-safe

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12319/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12319/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12319/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12319/merge#BCU1XR#0

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12319/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12319/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12319/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12319/merge#BCU1XR#0

@RaananW RaananW merged commit fb792c6 into BabylonJS:master Apr 1, 2022
@RaananW RaananW deleted the revampDeclarations branch April 1, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant