Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] LightEstimation feature #11117

Merged
merged 15 commits into from
Sep 20, 2021
Merged

[XR] LightEstimation feature #11117

merged 15 commits into from
Sep 20, 2021

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Sep 20, 2021

Closing #8904

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks pretty coool to me :-)

src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Show resolved Hide resolved
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits!

src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Outdated Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Show resolved Hide resolved
src/XR/features/WebXRLightEstimation.ts Show resolved Hide resolved
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG !!!!

@sebavan sebavan merged commit 4ceb5f2 into BabylonJS:master Sep 20, 2021
@RaananW RaananW deleted the lightEstimation branch September 20, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants