level output for the TextureBlock / switch for disabling level multiplication

[rassie]

This PR is a playground for the discussion in https://forum.babylonjs.com/t/nme-make-texture-level-work-for-normal-maps-as-it-does-in-other-materials/19443/14. This code currently does not work (at all!), but might work someday.

[sebavan]

LGTM aside the // FIXME block which needs to be removed. @Popov72 will provide a more in depth analysis :-)

[rassie]

LGTM aside the // FIXME block which needs to be removed.

Yeah, I couldn't find the reason for that. Would look into it again later today, but would also appreciate any help with that. Maybe there is something obvious that I've overlooked.

[rassie]

@sebavan @Popov72 have found and fixed the FIXME problem. This patch should be complete now.

[sebavan]

@rassie, you have one lint issue:

And you should credit yourself in the dist/preview release/whats new.md file

So that the build will be all green and happy.

@Popov72 will do the thorough review soon.

[rassie]

Done!

[Popov72]

LGTM: Great job!

One small thing is that 3 functions have been removed from bumpFragmentFunctions.fx and that could be a breaking change if someone was using them...

However, I don't think this code was supposed to be called by external users and having 3 x perturbNormal + 2 x cotangent_frame functions reduced to 1 x perturbNormal + 1 x cotangent_frame sounds good to me, so let's keep it!

[rassie]

LGTM: Great job!

One small thing is that 3 functions have been removed from bumpFragmentFunctions.fx and that could be a breaking change if someone was using them...

However, I don't think this code was supposed to be called by external users and having 3 x perturbNormal + 2 x cotangent_frame functions reduced to 1 x perturbNormal + 1 x cotangent_frame sounds good to me, so let's keep it!

It's a good thing there is a 5.0 release coming then ;) I'll fix the nits in a couple of hours when I'm not on mobile! Thanks!

[rassie]

Nits are done, thanks for the feedback!