aria-current #144
Open
aria-current #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Passing run #118 ↗︎
Details:
Review all test suite changes for PR #144 ↗︎ |
|||||||||||||||
✅ Deploy Preview for vue-ssr-carousel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level access audit for COR flagged this as a high priority issue. Basically they are saying that
aria-disabledshouldn't be how we set the active slide dot state. They suggestaria-current.I tested this simple change locally, and things seem to be fine, but I wanted to show you in case you think of some other reasons why we shouldn't do this.
One ramification is that if other sites update the carousel package, they will need to update any custom styling that hooks into the disabled attribute...
From level access:
