Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade action to use node20 #121

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Upgrade action to use node20 #121

merged 9 commits into from
Feb 8, 2024

Conversation

bonddim
Copy link
Contributor

@bonddim bonddim commented Jan 27, 2024

  • Bump all dependencies to use node20
  • Bump stableHelmVersion to v3.13.3 (latest patch of previous minor version)
  • Rewrite getLatestHelmVersion() function with @octokit/action
  • Bump versions of used actions in workflows to latest
  • Added integration test for latest version
  • Sets github.token as default input

Fixes #120
Fixes #117
Closes #116
Closes #115
Closes #114
Closes #112

- Bump all dependencies
- Rewrite `getLatestHelmVersion()` function without graphql
@bonddim bonddim requested a review from a team as a code owner January 27, 2024 22:21
@bonddim bonddim marked this pull request as draft January 28, 2024 08:51
@bonddim bonddim marked this pull request as ready for review January 28, 2024 09:59
@hangai247
Copy link

I think this change is going to be a Breaking change that should create a new action version azure/setup-helm@v4. Since all our workflows that are utilizing this action have started giving Nodejs v16 deprecation warnings, looking forward to the merging of this pull request.

@tamer-abdulghani
Copy link

Any idea about the date for the new release?

@bonddim
Copy link
Contributor Author

bonddim commented Feb 1, 2024

I think this change is going to be a Breaking change that should create a new action version azure/setup-helm@v4. Since all our workflows that are utilizing this action have started giving Nodejs v16 deprecation warnings, looking forward to the merging of this pull request.

Any updates?
There are no breaking changes for users - action will be usable with v3

- uses: azure/setup-helm@v3
  with:
    ...

You may bump major version to indicate the runtime change.

src/run.ts Show resolved Hide resolved
@jkroepke
Copy link

jkroepke commented Feb 2, 2024

There are no breaking changes for users

The runtime change must be indicated as breaking change, since it may break on private runners or GHES

@davidgamero
Copy link
Collaborator

@hangai247 yes we can cut a new release once this is merged

davidgamero
davidgamero previously approved these changes Feb 5, 2024
action.yml Outdated Show resolved Hide resolved
src/run.ts Show resolved Hide resolved
@davidgamero davidgamero merged commit 208de6b into Azure:main Feb 8, 2024
4 checks passed
@bonddim bonddim deleted the action-update branch February 8, 2024 18:51
@minauteur
Copy link

Any word on when a v4 release will be cut?

@davidgamero
Copy link
Collaborator

tracking here #125

on target by end of this week at the latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Action is reported as deprecated Upgrade action to use node20
8 participants