Wanl/fix fist preview version bump #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
approved these changes
Jul 22, 2024
tools/js-sdk-release-tools/src/mlc/apiVersion/apiVersionTypeExtractor.ts
Show resolved
Hide resolved
tools/js-sdk-release-tools/src/mlc/apiVersion/apiVersionTypeExtractor.ts
Show resolved
Hide resolved
tools/js-sdk-release-tools/src/mlc/apiVersion/apiVersionTypeExtractor.ts
Show resolved
Hide resolved
WhitShake
pushed a commit
to WhitShake/azure-sdk-tools
that referenced
this pull request
Jul 24, 2024
# Issue Azure#8522 # Problem The bug is introduced by new codegen [pr](Azure/autorest.typescript@b0853b2). The way to define default api version is changed. extracting the api version should also consider version of codegen. e.g. new api-version at client level is defined [here](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/mongocluster/arm-mongocluster/src/rest/documentDBClient.ts#L23) while old one is: - [here](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/face/ai-vision-face-rest/src/faceClient.ts#L26) - [another](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/openai/openai-rest/src/openAIClient.ts#L22) # Solution 1. try to detect in new client, return api-version if found 2. fallback to detect old client, return whatever found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#8522
Problem
The bug is introduced by new codegen pr. The way to define default api version is changed.
extracting the api version should also consider version of codegen.
e.g. new api-version at client level is defined here
while old one is:
Solution