Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete session implementation; C++ related changes #1822

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

LarryOsterman
Copy link
Member

@LarryOsterman LarryOsterman commented Sep 25, 2024

This pull request includes several changes to the AmqpSessionApis implementation and related components to improve functionality and code maintainability. The key changes involve refactoring how session options are accessed, implementing the end method, and modifying the AmqpSessionOptions builder.

Improvements to session options access:

  • Changed AmqpSessionOptions to use getter methods instead of directly accessing fields. (sdk/core/azure_core_amqp/src/fe2o3/session.rs, [1] [2]
  • Updated AmqpSessionOptions to include getter methods for all fields. (sdk/core/azure_core_amqp/src/session.rs, sdk/core/azure_core_amqp/src/session.rsL18-R65)

Implementation of end method:

Modifications to AmqpSessionOptions builder:

Other changes:

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing blocking.

sdk/core/azure_core_amqp/src/fe2o3/session.rs Outdated Show resolved Hide resolved
sdk/core/azure_core_amqp/src/fe2o3/cbs.rs Show resolved Hide resolved
sdk/core/azure_core_amqp/src/fe2o3/connection.rs Outdated Show resolved Hide resolved
@LarryOsterman LarryOsterman enabled auto-merge (squash) September 27, 2024 20:57
@LarryOsterman LarryOsterman merged commit 7d1b96c into Azure:feature/track2 Sep 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants