-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete session implementation; C++ related changes #1822
Merged
LarryOsterman
merged 12 commits into
Azure:feature/track2
from
LarryOsterman:larryo/rust_session
Sep 27, 2024
Merged
complete session implementation; C++ related changes #1822
LarryOsterman
merged 12 commits into
Azure:feature/track2
from
LarryOsterman:larryo/rust_session
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
requested review from
heaths,
RickWinter and
JeffreyRichter
as code owners
September 25, 2024 17:33
heaths
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see nothing blocking.
heaths
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
AmqpSessionApis
implementation and related components to improve functionality and code maintainability. The key changes involve refactoring how session options are accessed, implementing theend
method, and modifying theAmqpSessionOptions
builder.Improvements to session options access:
AmqpSessionOptions
to use getter methods instead of directly accessing fields. (sdk/core/azure_core_amqp/src/fe2o3/session.rs
, [1] [2]AmqpSessionOptions
to include getter methods for all fields. (sdk/core/azure_core_amqp/src/session.rs
, sdk/core/azure_core_amqp/src/session.rsL18-R65)Implementation of
end
method:end
method inAmqpSessionApis
to properly end the session. (sdk/core/azure_core_amqp/src/fe2o3/session.rs
, sdk/core/azure_core_amqp/src/fe2o3/session.rsL101-R111)Modifications to
AmqpSessionOptions
builder:AmqpSessionOptionsBuilder
to use mutable references and clone options for thebuild
method. (sdk/core/azure_core_amqp/src/session.rs
, sdk/core/azure_core_amqp/src/session.rsL86-R167)test_amqp_session_options_builder
test to reflect changes in the builder pattern. (sdk/core/azure_core_amqp/src/session.rs
, sdk/core/azure_core_amqp/src/session.rsL141-R180)Other changes:
Uuid
import to a type alias. (sdk/core/azure_core_amqp/src/lib.rs
, sdk/core/azure_core_amqp/src/lib.rsL19-R19)