-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support national clouds in search #25705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Search
label
Aug 15, 2022
xiangyan99
reviewed
Aug 15, 2022
xiangyan99
reviewed
Aug 15, 2022
kashifkhan
reviewed
Aug 15, 2022
kashifkhan
reviewed
Aug 15, 2022
rakshith91
commented
Aug 15, 2022
xiangyan99
reviewed
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does search support Azure Stack?
no - they don't |
API change check APIView has identified API level changes in this PR and created following API reviews. |
xiangyan99
approved these changes
Aug 16, 2022
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2022
* Support national clouds in search * Update sdk/search/azure-search-documents/README.md * lint * lint
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
* Support national clouds in search * Update sdk/search/azure-search-documents/README.md * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines