Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[communication-identity] [Reland] Add methods to translate CommunicationIdentifier to / from a stable string format #25696

Conversation

prprabhu-ms
Copy link
Contributor

This PR relands #25668 (with a minor fix on top from #24460)

Previous PR was reverted in order to allow an unrelated release from main while the API in this PR was under active API council review (across all languages).

Description

This PR address the API review council feedback on this feature branch.

The changes are minimial:

  • Add a previously missing type in the package exports.
  • Add type annotations to newly added functions.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-identity

@DominikMe DominikMe merged commit ca7ce9e into Azure:main Aug 15, 2022
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
…ionIdentifier to / from a stable string format (Azure#25696)

* reverted back rawid changes

* Export a missing type and add type annotations (Azure#25668)
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
…ionIdentifier to / from a stable string format (Azure#25696)

* reverted back rawid changes

* Export a missing type and add type annotations (Azure#25668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants