Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None-check when computing md5 #25655

Merged
merged 4 commits into from
Aug 11, 2022
Merged

None-check when computing md5 #25655

merged 4 commits into from
Aug 11, 2022

Conversation

Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Aug 10, 2022 •
edited
Loading

Description

Fix for #25489. Our md5 method was not considering the possibility that a request's content could be None instead of b"". Since from an HTTP perspective None and b"" are the same, we just add a simple None-check,

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Aug 10, 2022
@Stevenjin8 Stevenjin8 marked this pull request as ready for review August 10, 2022 20:48
jalauzon-msft
jalauzon-msft reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Change looks good to me. Just some comments on the CHANGELOG and test. Let me know if you have any questions.

sdk/storage/azure-storage-blob/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/tests/test_blob_client.py Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jalauzon-msft
jalauzon-msft approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@jalauzon-msft jalauzon-msft merged commit 2d7e636 into main Aug 11, 2022
@jalauzon-msft jalauzon-msft deleted the fix/upload-empty-blob branch August 11, 2022 18:53
@jalauzon-msft jalauzon-msft restored the fix/upload-empty-blob branch August 11, 2022 18:53
@jalauzon-msft jalauzon-msft deleted the fix/upload-empty-blob branch August 11, 2022 18:53
@jalauzon-msft jalauzon-msft mentioned this pull request Aug 11, 2022
Closed
@Stevenjin8 Stevenjin8 mentioned this pull request Aug 15, 2022
Closed
6 tasks
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
@wonder6845
[Storage] None-check when computing md5 (Azure#25655)
9bf68ff
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 27, 2023
CodeGen from PR 25655 in Azure/azure-rest-api-specs
e936745 
[Hub Generated] Review request for Microsoft.Security to add version preview/2023-10-01-preview (Azure#25655)

* Adds base for updating Microsoft.Security from version preview/2023-03-01-preview to version 2023-10-01-preview

* Updates readme

* Updates API version in new specs and examples

* read.me fix

* fix compiste version

* add ciem configuration to new security connector

* update ciem description

* add ciem to custom words

* add containers changes

* add vm scanners to GCP DCSPM

* add data sensitivity discovery

* add containers to defender for containers

* add containers to GCP containers and DCSPM

* run prettier

* fix readme file

* remove old version from compsite package

* add scan interval to examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stevenjin8 @azure-sdk @jalauzon-msft