-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[formrecognizer] Build model update #25416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Cognitive - Form Recognizer
label
Jul 27, 2022
catalinaperalta
commented
Jul 27, 2022
...zer/azure-ai-formrecognizer/azure/ai/formrecognizer/_document_model_administration_client.py
Show resolved
Hide resolved
catalinaperalta
commented
Jul 27, 2022
...zer/azure-ai-formrecognizer/azure/ai/formrecognizer/_document_model_administration_client.py
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
catalinaperalta
force-pushed
the
buildModelUpdate
branch
from
July 27, 2022 19:05
a5eee00
to
e1267e1
Compare
catalinaperalta
requested review from
kristapratico and
iscai-msft
as code owners
July 29, 2022 00:10
catalinaperalta
requested review from
samvaity,
witemple-msft,
HarshaNalluru and
kinelski
July 29, 2022 21:01
kristapratico
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
samvaity
reviewed
Aug 1, 2022
@@ -6,6 +6,8 @@ | |||
- Added `TargetAuthorization` of type `dict[str, str]`. | |||
|
|||
### Breaking Changes | |||
- Renamed `source` argument to `blob_container_url` on `begin_build_model()`. | |||
- Changed argument order on `begin_build_model()`. `build_mode` is the first expected argument, followed by `blob_container_url`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why we made this change?
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2022
* rename source param and reorder * changelog, docs, samples updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
begin_build_model()
to be more flexible for future design work. Also renamingsource
toblob_container_url
.