Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] updates for integrated cache PR #25391

Merged
merged 8 commits into from
Jul 29, 2022
Merged

[Cosmos] updates for integrated cache PR #25391

merged 8 commits into from
Jul 29, 2022

Conversation

JericHunter
Copy link
Contributor

@JericHunter JericHunter commented Jul 25, 2022 •
edited
Loading

Removed anything that says preview or beta or provisional, etc. Also made some changelog/readme changes.

@ghost ghost added the Cosmos label Jul 25, 2022
simorenoh
simorenoh approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@simorenoh simorenoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, other than that it's good thanks Jeric!

@JericHunter JericHunter marked this pull request as ready for review July 25, 2022 20:45
simorenoh
simorenoh requested changes Jul 28, 2022
View reviewed changes
Copy link
Member

@simorenoh simorenoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the approval while we make changes to the README as well.

simorenoh
simorenoh approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@simorenoh simorenoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing but lgtm! thanks Jeric!

@JericHunter JericHunter merged commit e29b1db into main Jul 29, 2022
@JericHunter JericHunter deleted the jh-integrated-cache branch July 29, 2022 21:38
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
@JericHunter @wonder6845
[Cosmos] updates for integrated cache PR (Azure#25391)
1bb2b4b 
* Update _container.py

* Update container.py

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott left review comments

@simorenoh simorenoh simorenoh approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JericHunter @tjprescott @simorenoh