Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Skip tests when vault SKU is incompatible #25270

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jul 18, 2022

Description

I recently got our weekly sovereign cloud tests running again, and test runs show that some tests -- namely, those that deal with key release -- require a premium vault SKU in order to work. Standard SKUs are used in China cloud tests, so we need to skip these when necessary.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable test-sovereign-cloud labels Jul 18, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mccoyp mccoyp requested a review from YalinLi0312 July 21, 2022 17:53
@mccoyp
Copy link
Member Author

mccoyp commented Jul 29, 2022

/check-enforcer evaluate

@mccoyp
Copy link
Member Author

mccoyp commented Jul 29, 2022

/check-enforcer override

@mccoyp mccoyp merged commit eeae1f1 into Azure:main Jul 29, 2022
@mccoyp mccoyp deleted the kv-tests-weekly branch July 29, 2022 21:14
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable test-sovereign-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants