Loadtestservice - SDK initial review #24744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
reviewed
Jun 13, 2022
sdk/loadtestservice/azure-analytics-loadtestservice/MANIFEST.in
Outdated
Show resolved
Hide resolved
msyyc
reviewed
Jun 13, 2022
|
Hi @Yashikaj14 DPG tool generates framework for SDK and there are some files (README.md, test, samples) that need to be customized by you for better usage experience of customers.
|
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…-sdk-for-python into loadtestservice
|
Hi @Yashikaj14 The test actually does not run. Please follow https://github.com/Azure/azure-sdk-for-python/wiki/Dataplane-Codegen-Quick-Start-for-Test to update test. You could also refer to test of other service: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/purview/azure-purview-administration/tests/test_smoke.py |
msyyc
reviewed
Jun 20, 2022
sdk/loadtestservice/azure-analytics-loadtestservice/samples/sample.py
Outdated
Show resolved
Hide resolved
msyyc
reviewed
Jun 20, 2022
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
msyyc
reviewed
Jun 21, 2022
sdk/loadtestservice/azure-analytics-loadtestservice/tests/test_smoke_async.py
Outdated
Show resolved
Hide resolved
msyyc
reviewed
Jun 21, 2022
iscai-msft
approved these changes
Jun 27, 2022
iscai-msft
reviewed
Jun 27, 2022
...service/azure-analytics-loadtestservice/azure/analytics/loadtestservice/operations/_patch.py
Outdated
Show resolved
Hide resolved
msyyc
approved these changes
Jul 5, 2022
iscai-msft
reviewed
Jul 12, 2022
|
|
||
| #### Prequisites | ||
|
|
||
| - Python 3.6 or later is required to use this package. |
There was a problem hiding this comment.
we're dropping support for 3.6, so we can require 3.7 and up in the readme and in the setup.py
| Use the returned token credential to authenticate the client: | ||
|
|
||
| ```python | ||
| >>> from azure.analytics.loadtestservice import LoadTestClient |
There was a problem hiding this comment.
generally we have our readme examples as runnable code, this is a transcription of using the code in the python shell. For example, it's usually like
from azure.analytics.loadtestservice import LoadTestClient
from azure.identity import DefaultAzureCredential
...That way users can copy paste into their own code editor and run the code
| self, | ||
| credential: "TokenCredential", | ||
| *, | ||
| endpoint: str = "https://<dataPlaneURL>", |
There was a problem hiding this comment.
this doesn't look like a valid url, I don't think we should default to this value. I'm thinking endpoint should be required since this default value seems invalid
| **kwargs | ||
| ) -> JSON: | ||
| """ | ||
| Uploading a test file |
There was a problem hiding this comment.
there should be documentation for each of the params, you can look at the generated code to see what we usually have for documentation
| # Set the values of the client ID, tenant ID, and client secret of the AAD application as environment variables: | ||
| # AZURE_CLIENT_ID, AZURE_TENANT_ID, AZURE_CLIENT_SECRET, LOADTESTSERVICE_ENDPOINT | ||
| try: | ||
| endpoint = os.environ["LOADTESTSERVICE_ENDPOINT"] |
There was a problem hiding this comment.
nit: you can just rely on the KeyError here, i.e. you can just do endpoint = os.environ["LOADTESTSERVICE_ENDPOINT"] and an appropriate error will be thrown
| ), | ||
| install_requires=[ | ||
| "azure-core<2.0.0,>=1.23.0", | ||
| "msrest>=0.6.21", |
There was a problem hiding this comment.
do you actually need an msrest dependency? I don't think you do. I recommend you remove this dependency unless absolutely necessary. You will probably have to add an isodate dependency, you can look at the changelog to see our mindep versions
| clear-output-folder: true | ||
| no-namespace-folders: true | ||
| title: LoadTestClient | ||
| version-tolerant: true |
There was a problem hiding this comment.
nit: no need for version-tolerant: true anymore bc we now default to version tolerant
| assert result is not None | ||
|
|
||
| @LoadtestservicePowerShellPreparer() | ||
| def test_smoke_delete_test(self, loadtestservice_endpoint): |
There was a problem hiding this comment.
please add a test for upload_file_test bc that's a handwritten method
There was a problem hiding this comment.
Duplicate at: #25264 (comment)
msyyc
reviewed
Jul 20, 2022
| "words":[ | ||
| "vusers" | ||
| ] | ||
| }, |
lmazuel
pushed a commit
that referenced
this pull request
Jul 29, 2022
* SDK generated autorest * upload function added * patch.py changed * upload updated * whl file removed * whls deleted * aio updated * spell check added * spell check * Update shared_requirements.txt * Update MANIFEST.in Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update setup.py Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * spell added * patch.py updated * linting corrected * Update allowed_pylint_failures.py * readme updated * patch.py updation * Update _patch.py * tests added * async naming * test and result * push the test result * fix * fix * tests added and async built * yaml added * yaml updated * sample and readme updated * fix ci.yml * more tests and samples addded and readme updated * tests * fix * fix2 * type added * type added * Update CHANGELOG.md * chnaged to developer * renamed package * chnaged ci files * linting fixes * changed namespace from analytics to developer * app_component naming cleaned * folded get_app_component * various name changes and added type hinting * lint changes * added wrapper for LoadTestClient * removed msrest dependencies * corrected Serializer method * test_smoke fixed * fixes in aio class * updates samples * namespace chg AppComponent, serverMetrics, test * updated samples * namespace changes done * LoadTestClient -> LoadTestingClient * apnd load_test to test_run & adminstration * added Readme Descirption * few changes in tests * moved SUBSCRIPTION_ID to .env * resloved readme issues by @iscai-msft in #24744 * resolved #discussion_r925248158 * resolving other issue by @iscai-msft #24744 * #25264#discussion_r925284462 * cleaned tests * namechanges * resolved folding issues * fixing dependencies verison * added tests for _patch(es) * removed subs id from recordings * fixing isodate requirements * removed SaaS key from smoke test * folder name chnage + setup.py cleaned * Readme changes suggested by @msyyc * added dependencies in shared_requirements.txt * removed os.environ from tests * liniting * removed async test * fixing tests * ci fix try * trying dev_tools * fix for azure-mgmt-loadtestservice dev_reqs * added async tests * some tests * cleaned setup * fixing async tests * added mgmt to loadtestservice to ci * changed fie mode from json to BinaryIO * reverting merge by @BigCat20196 * removed TEST_ID * solving issues by @lmazuel * update with autorest6.1.0 and update tests * update and format * fix playback failed * Update test_smoke.test_create_or_update_test_run.yaml * Update test_smoke.test_smoke_create_or_update_test.yaml * Update test_smoke_async.test_smoke_create_or_update_test.yaml * updated README Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: BigCat20196 <1095260342@qq.com>
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2022
* SDK generated autorest * upload function added * patch.py changed * upload updated * whl file removed * whls deleted * aio updated * spell check added * spell check * Update shared_requirements.txt * Update MANIFEST.in Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update setup.py Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * spell added * patch.py updated * linting corrected * Update allowed_pylint_failures.py * readme updated * patch.py updation * Update _patch.py * tests added * async naming * test and result * push the test result * fix * fix * tests added and async built * yaml added * yaml updated * sample and readme updated * fix ci.yml * more tests and samples addded and readme updated * tests * fix * fix2 * type added * type added * Update CHANGELOG.md * chnaged to developer * renamed package * chnaged ci files * linting fixes * changed namespace from analytics to developer * app_component naming cleaned * folded get_app_component * various name changes and added type hinting * lint changes * added wrapper for LoadTestClient * removed msrest dependencies * corrected Serializer method * test_smoke fixed * fixes in aio class * updates samples * namespace chg AppComponent, serverMetrics, test * updated samples * namespace changes done * LoadTestClient -> LoadTestingClient * apnd load_test to test_run & adminstration * added Readme Descirption * few changes in tests * moved SUBSCRIPTION_ID to .env * resloved readme issues by @iscai-msft in Azure#24744 * resolved #discussion_r925248158 * resolving other issue by @iscai-msft Azure#24744 * Azure#25264#discussion_r925284462 * cleaned tests * namechanges * resolved folding issues * fixing dependencies verison * added tests for _patch(es) * removed subs id from recordings * fixing isodate requirements * removed SaaS key from smoke test * folder name chnage + setup.py cleaned * Readme changes suggested by @msyyc * added dependencies in shared_requirements.txt * removed os.environ from tests * liniting * removed async test * fixing tests * ci fix try * trying dev_tools * fix for azure-mgmt-loadtestservice dev_reqs * added async tests * some tests * cleaned setup * fixing async tests * added mgmt to loadtestservice to ci * changed fie mode from json to BinaryIO * reverting merge by @BigCat20196 * removed TEST_ID * solving issues by @lmazuel * update with autorest6.1.0 and update tests * update and format * fix playback failed * Update test_smoke.test_create_or_update_test_run.yaml * Update test_smoke.test_smoke_create_or_update_test.yaml * Update test_smoke_async.test_smoke_create_or_update_test.yaml * updated README Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: BigCat20196 <1095260342@qq.com>
lmazuel
pushed a commit
that referenced
this pull request
Oct 20, 2022
* SDK generated autorest * upload function added * patch.py changed * upload updated * whl file removed * whls deleted * aio updated * spell check added * spell check * Update shared_requirements.txt * Update MANIFEST.in Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update setup.py Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * spell added * patch.py updated * linting corrected * Update allowed_pylint_failures.py * readme updated * patch.py updation * Update _patch.py * tests added * async naming * test and result * push the test result * fix * fix * tests added and async built * yaml added * yaml updated * sample and readme updated * fix ci.yml * more tests and samples addded and readme updated * tests * fix * fix2 * type added * type added * Update CHANGELOG.md * chnaged to developer * renamed package * chnaged ci files * linting fixes * changed namespace from analytics to developer * app_component naming cleaned * folded get_app_component * various name changes and added type hinting * lint changes * added wrapper for LoadTestClient * removed msrest dependencies * corrected Serializer method * test_smoke fixed * fixes in aio class * updates samples * namespace chg AppComponent, serverMetrics, test * updated samples * namespace changes done * LoadTestClient -> LoadTestingClient * apnd load_test to test_run & adminstration * added Readme Descirption * few changes in tests * moved SUBSCRIPTION_ID to .env * resloved readme issues by @iscai-msft in #24744 * resolved #discussion_r925248158 * resolving other issue by @iscai-msft #24744 * #25264#discussion_r925284462 * cleaned tests * namechanges * resolved folding issues * fixing dependencies verison * added tests for _patch(es) * removed subs id from recordings * fixing isodate requirements * removed SaaS key from smoke test * folder name chnage + setup.py cleaned * Readme changes suggested by @msyyc * added dependencies in shared_requirements.txt * removed os.environ from tests * liniting * removed async test * fixing tests * ci fix try * trying dev_tools * fix for azure-mgmt-loadtestservice dev_reqs * added async tests * some tests * cleaned setup * fixing async tests * added mgmt to loadtestservice to ci * changed fie mode from json to BinaryIO * reverting merge by @BigCat20196 * removed TEST_ID * solving issues by @lmazuel * update with autorest6.1.0 and update tests * update and format * fix playback failed * Update test_smoke.test_create_or_update_test_run.yaml * Update test_smoke.test_smoke_create_or_update_test.yaml * Update test_smoke_async.test_smoke_create_or_update_test.yaml * updated README * test case of app components create * delete_app_components fixed * complete testing for AppComponent Class * tested create_or_update_test * client.load_test_administration.delete_load_test * tests for get_load_test * tested upload_test_file * complete TestOperations testing * removed sas keys from recordings * corrected name error * corrected sample and added tests for test_run(1/2) * TestRun testing done * completed ServerMetrics testing * remove SAS key from files * removing SAS key * Update README.md * Update README.md * Update README.md * Update README.md * some work in tests * cleaned samples as per @ninallam * updated CHANGELOG.md * updated CHANGELOG.md * trying to fix chnagelog CI * migrate tests to testproxy * added changes suggested by @ninallam & @msyyc * updated change log * Update README.md * fixed issues with sample * fix playback failed * Update sdk/loadtestservice/azure-developer-loadtesting/CHANGELOG.md * Update CHANGELOG.md * fix playback failed * Fix changelog * Update _version.py * Update CHANGELOG.md * added bug explanation in Readme file. * removed samples and test cases from Changelog * added resource creation example in samples for mgmt plane * fixed sample resource creation link * adding ref to DefaultAzureCredential * refactor mgmt sample file * broken samples into files * fixed samples as disucssed with @iscai-msft * added few access to reult dict * update tests and recordings * Update README.md * fixed typo, matrics -> metrics * fixed typo, matrics -> metrics * update test recording * rename non test files * improved samples as per @ninallam * simplified check validation in SDK * resolved comments by @iscai-msft * pushing new design for validation checking * minor changes * removed LRO operations * minor fixes * started async tests * pushing more tests * completed corresponding async tests * removed mgmt plane samples * fixing broken link * ran black * chnaged security scope * Update CHANGELOG.md * Update conftest.py * updated README * added troubleshooting section * minor fixes Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: BigCat20196 <1095260342@qq.com> Co-authored-by: Nikita Nallamothu <50437471+ninallam@users.noreply.github.com>
xiangyan99
added a commit
that referenced
this pull request
Oct 27, 2022
* [SchemaRegistry] docs/update release date (#26736) * [Storage] Fix flaky test in `test_file.py` migration (#26735) * Be gone flaky test * Live only tag * Default variable empty pop * RC (#26733) * [AutoRelease] t2-resource-2022-10-10-38276(Do not merge) (#26724) * code and test * fix test Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-dataprotection-2022-10-03-74033(Do not merge) (#26590) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * code and test (#26745) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * feat: support setting path for node output directly (#26712) * feat: support setting path for node output directly * fix: fix ci * refactor: remove redundant _inputs_outputs.py (#26714) * fix broken links (#26746) * Update service client and client and add new api version (#25865) * Update service client and client and add new api version * Update parameter type * Add tests, update test recordings, samples, readme and changelog * Rename token expiration parameter based on review * reverted back unwanted changes in ml sdk * fixed doctype * fixed linting issues Co-authored-by: Aigerim Beishenbekova <aigerimb@microsoft.com> * Search deeper in from_config so that config.json is found in Compute Instance (#26737) * Add DictMixin to easy AML SDK classes (#26365) * copy ADO branch changes into GH branch * sync with closed source comments * fix merge issues * continue to fix changelog file merge issues * move CL entry to correct section * Increment package version after release of azure-identity (#26749) * Add schema links to error messages resolution section (#26646) * Add specific datastore types to ErrorTarget enum * Add schema links to error messages resolution sections * Add test * Update datastore ErrorTarget enum * Update to use proper key for yaml ref doc dictionary * Fix pylint errors * Update Resolution message * Update Resolution message * Update test * Update test * Fix broken symlink test * target version with fixes (#26702) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Update the release versions for ML SDK (#26752) * Update the release versions for ML SDK * Update the readme for ML project for GA * Update version in setup file * Increment package version after release of azure-servicebus (#26765) * Increment version for tables releases (#26767) Increment package version after release of azure-data-tables * Increment version for storage releases (#26761) Increment package version after release of azure-storage-file-share * Update swagger_to_sdk_config_autorest.json (#26772) * [Storage] Migrate `test_share` to test proxy (file-share) (#26709) * Live sync done * Sync recorded done * Fix imports * Async live done * All passing async recorded * Fix imports again * Fix requests import ordering * [Storage] Migrate `test_file_service_properties.py` to test proxy (file-share) (#26770) * Delete and initial script run * Finished sync * Fixed .yaml being generated, all passing * [Storage] Migrate `test_get_file.py` to test proxy migration (file-share) (#26764) * Finished live after changing test acc * All passing live async * All passing live and recorded, reorder imports * [AutoRelease] t2-elasticsan-2022-09-19-73442(Do not merge) (#26291) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * [AutoRelease] t2-appcontainers-2022-10-05-17273(Do not merge) (#26634) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * fix: combo fix for internal components I (#26718) * fix: support data-binding expression on internal node runsettings * fix: raise error if unknown field errors are met in load_funcs * fix: support is_control output for internal components * feat: ignore unknown fields on internal output port definition instead of raising error * feat: enable hdinsight.compute_name * feat: support dependency files in additional_includes * feat: convert hdinsight.compute_name to arm str * feat: load all internal nodes to their own entity class instead of base node * resolve comment add * to validation class method remove super class for InternalOutputSchema * Fix sampleRate in AppInsightsSampler (#26771) * [Communication] - Phone Numbers - Use static connection string in azure-communication-phonenumber tests (#26775) * Use static connection string in phonenumber tests * Use static connection string for SIP tests * [Storage] Fix type hints for classmethods in Blob and Datalake (#26611) * [Storage] Adjust type hints for __init__ and classmethods in file-share, queue, and changefeed (#26743) * Bump the code owner retriver version. (#26789) Co-authored-by: sima-zhu <sizhu@microsoft.com> * [AutoRelease] t2-network-2022-10-10-01607(Do not merge) (#26726) * code and test * test fix * changelog date Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-securitydevops-2022-10-12-19159(Do not merge) (#26777) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * refactor: divide pipeline._io into a package (#26781) * [auto release] add `dev_requirements.txt` for new service to pass CI (#26799) * dev_requirement * code * Create dev_requirements.txt (#26802) * Update elasticsan requirements (#26804) Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> * feat: re-enable failed dsl tests (#26782) * feat: re-enable test_dsl_pipeline_samples.py * feat: re-enable skipped tests in test_dsl_pipeline.py * feat: re-enable left skipped tests * [ML][Pipeline] Fix sub graph job download (#26803) * Add schedule doc string, fix job download Signed-off-by: Brynn Yin <biyi@microsoft.com> * Enable create pipeline component from job test Signed-off-by: Brynn Yin <biyi@microsoft.com> * Add job compute validate test Signed-off-by: Brynn Yin <biyi@microsoft.com> * Fix docstring Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * Add more example of transport (#26768) * Add more example of transport See #26757 * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md * Update CLIENT_LIBRARY_DEVELOPER.md Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * allow subscription-only requests for registry list operation (#26674) * allow subscription only list calls for registry list * cl * change scope values to constant, correct ml * correct lower call * use scope constants for WS list function * move cl entry to correct file. * correct cl again * fix changelog syntax * [Azure Maps] - Onboarding for Render SDK (#24893) * init PR * Update samples * Add Unit/Live test Update testresopurce.json Update Minor Update * Update according to feedback * Code clean up * Update API to the newest version * Update to fix CI issue * Add recording files * update according to comment * Update docstrings * udpate accordingly * Update according to feedback * update minors according to feedback * update release date * skip aad tests since they fail in PPE (#26808) * [Storage] Remove `msrest` dependency (#26739) * update changelog date and ref docs (#26811) * Azure App Configuration Provider Beta (#26016) * Adding azure-appconfiguration-provider * Fixing repo issue * Fixing repo issue * Updated to setup user agent and header info * Updating to cache secret_clients * Fixed Naming * Fixed Typo * Added Samples, Fixed issue with Key Vault Options not set when secret is in store. * Fixed SP, Dependency, and Pylint issues * Fixed more lint issues, moved key vault references to be a method * More Linting fixes * Fixing dependency issues with build * Updated Docs. Fixed extra code for Key Vault Usage. Updated Readme to include a list of features and future features. Added Clients sample for Key Vault. * Adding Test Case, currently doesn't work * Fixing Tests * Fixing Trim. Fixing Typo in readme. * Fixing Length and vault_url issues. * Updating from code review comments * Added more error checking. Made Key_VAULT_SECRET_PREFIX a constant. * Updated to use Key Vault Identifier. * Fixed Spelling * Updated Test * Reworked key vault reference resolution. Fixed lint issues. * Fixing Lint Issue. Updating Test Running * Fixing Tests * Fixed Tests? * Setting secret clients to {} if none. Adding override to shared_requirements * Updating shared requirements * Fixed override. Switched to SecretReferenceConfigurationSetting * Updated Requirement KeyVaultSecretIdentifier is needed. * Update ci.yml * Update ci.yml * Fixed structure * Update dev_requirements.txt * Update sdk_packaging.toml * Revert working state * Renamed correctly * Using azure-appconfigurationprovider * Fixing shared Requirements merge issue * Updated from review comments * Fixing package folder * Fix lint, removed extra fixture * Create py.typed * Updated Manifest to use right py.typed file * Switched Files * Fixing lint issue * Setting defaults for test * Updating Docs * Fixing Whitespace * Updating to support in operation * Updated sample with in usage * Cleaned up key trimming usage * Removed extra catches for now. Cleaned up lint. * Adding more tests * Fixed Linting * Fixing Auto Format * Fixing Key Vault Reference Test * Trying to update the package name * Fixed formatting? * Adding azure-appconfiguration-provider * Fixing repo issue * Fixing repo issue * Updated to setup user agent and header info * Updating to cache secret_clients * Fixed Naming * Fixed Typo * Added Samples, Fixed issue with Key Vault Options not set when secret is in store. * Fixed SP, Dependency, and Pylint issues * Fixed more lint issues, moved key vault references to be a method * More Linting fixes * Fixing dependency issues with build * Updated Docs. Fixed extra code for Key Vault Usage. Updated Readme to include a list of features and future features. Added Clients sample for Key Vault. * Adding Test Case, currently doesn't work * Fixing Tests * Fixing Trim. Fixing Typo in readme. * Fixing Length and vault_url issues. * Updating from code review comments * Added more error checking. Made Key_VAULT_SECRET_PREFIX a constant. * Updated to use Key Vault Identifier. * Fixed Spelling * Updated Test * Reworked key vault reference resolution. Fixed lint issues. * Fixing Lint Issue. Updating Test Running * Fixing Tests * Fixed Tests? * Setting secret clients to {} if none. Adding override to shared_requirements * Updating shared requirements * Fixed override. Switched to SecretReferenceConfigurationSetting * Updated Requirement KeyVaultSecretIdentifier is needed. * Update ci.yml * Update ci.yml * Fixed structure * Update dev_requirements.txt * Update sdk_packaging.toml * Revert working state * Renamed correctly * Using azure-appconfigurationprovider * Fixing shared Requirements merge issue * Updated from review comments * Fixing package folder * Fix lint, removed extra fixture * Create py.typed * Updated Manifest to use right py.typed file * Switched Files * Fixing lint issue * Setting defaults for test * Updating Docs * Fixing Whitespace * Updating to support in operation * Updated sample with in usage * Cleaned up key trimming usage * Removed extra catches for now. Cleaned up lint. * Adding more tests * Fixed Linting * Fixing Auto Format * Fixing Key Vault Reference Test * Trying to update the package name * Removing Extra TestProxy * Not -e installing azure-appconfiguration * updates * update * update * Update sdk/appconfiguration/azure-appconfiguration-provider/setup.py Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> * update * Updated min version of app config * Updating sanitizer * Updating Shared Requirement * Temp removing key vault test * Removing actual tests Co-authored-by: Xiang Yan <xiangyan@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> * more readme fixes (#26815) * Increment version for cognitivelanguage releases (#26819) Increment package version after release of azure-ai-language-questionanswering * Update CHANGELOG.md (#26820) * Update CHANGELOG.md (#26821) * code and test (#26805) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Increment version for appconfiguration releases (#26823) Increment package version after release of azure-appconfiguration-provider * [Storage] Migrate `test_file_api_version.py` to test proxy (file-share) (#26812) * Initial script pass, sync done * Passing async * Fix imports * code and test (#26797) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Azure-communication-identity release updates (#26809) * [Azure Maps] - Onboarding for Route SDKs (#25101) * init * Update client, add samples * Update and expose models * Minor Update/clean up Update samples and tests Modify docstring * Delete and update uplicated intro in README * Update - Combine get route directions methods and post route directions methods - Minor update according to feedback * Update docstring * update test with test_proxy * update according to feedback * update to new autorest generated files * update exposed models * update according to feedback * update release date & minor naming & clean up` * Add overload methodst * fix pylint * [Storage] Add `aio` extra_requires to Storage packages (#26791) * Fix #26720, ContainerClient.from_container_url cannot work with URL ending with / (#26721) Co-authored-by: Yulin Li <Yulin.Li@microsoft.com> * [Asset-Sync] extensions to the test framework to allow external assets (#26078) * add updated logic to resolve assets.json and pass along to record|playback/start * ensure that parallel tox environments don't accidentally stomp on each other by updating where the local proxy assets are stored during CI runs * add assets cleanup to ensure we don't overfill the CI agents disks Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * [azure-sdk-tools] ensure trailing / in PROXY_URL can't mess with proxy startup (#26832) * [Storage] Migrate `test_file_client.py` to test proxy (file-share) (#26769) * Initial delete recordings + run migration script * Sync,live passing * Sync is done, async is failing live, but also qq on empty tests * Making async def even w/o async operations fixes double-backing on clients * Fix imports * Get rid of empty recordings, mark as live only * Removed live-only tag, still passes in live&recorded w/ no serv. call * [Key Vault] Move recordings into assets repository (#26837) * [TA] skip tests which are failing due to service bugs (#26838) * skip tests which are failing due to service bugs * fix with the correct link to the bug * Add Azure ML Pipeline CODEOWNERS (#26710) * update code owners * add more paths Co-authored-by: Clement Wang <clwan@microsoft.com> * [AutoRelease] t2-datafactory-2022-10-09-06495(Do not merge) (#26717) * code and test * Update CHANGELOG.md * Update _version.py * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: zhenbiao wei <424401670@qq.com> * Move back annotation conversion from mldesigner (#26843) Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * [Identity] Doc formatting fixes (#26664) - Fixed a few issues with docs not being rendered as expected on the api docs website. - Added a note in the DAC troubleshooting section for users who are directed there from an error regarding additionally_allowed_tenants configuration. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [Storage] Fix docs for `list_blobs` and `walk_blobs` (#26836) * [ML] Enable SDK data and datastore get calls to use new error message format (#26788) * enable SDK data and datastore get calls to use new error message format * Add registry delete operation (#26751) * initial delete files * delete swagger and autorest corrections * change delete param name * update recordings and e2e test * add changelog line * fix op return comments, make test require error on last op * remove unneeded variable declaration * Add else schema type value (#26858) * [Storage] Fix failing pipeline tests (`test_share.py`) + `name_starts_with` async bug fix (#26793) * Add playback only tag to failing live tests * Refactored to hopefully get rid of conflicts * Tests should pass now, fix prefix bug * Re-record test to fix CI * [Storage] Fix `isodate` dependency (#26874) * Add playback only tag to failing live tests * Refactored to hopefully get rid of conflicts * Tests should pass now, fix prefix bug * Re-record test to fix CI * Fix isodate dependency issue * remove msrest dependency introduced by merging main * one last fix * [Storage] Fix content range check for empty files (#26872) * skipping flaky bp test for now (#26829) * [EventHubs] exception/kwargs testing (#26867) * fix flushing list batches in bp * add send list bp test * Added test cases for Azure load testing management plane (#26842) * added sdk tests * removed recorded_by_proxy * updated test proxy setup as per recommendation * Update conftest.py * Update ci.yml * Update ci.yml Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-nginx-2022-10-13-60502(Do not merge) (#26796) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * [AutoRelease] t2-avs-2022-10-13-52806(Do not merge) (#26798) * code and test * Update CHANGELOG.md * Update CHANGELOG.md * Update _version.py Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [AutoRelease] t2-containerservice-2022-10-12-83343(Do not merge) (#26774) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Support e2e run for if_else node in pipeline (#26780) * add e2e test * update test * fix test * fix pipeline tests * add comment * fix test * merge swagger pipeline into one (#26846) * code * code * feat: avoid serialize input value from int string to float (#26878) * fix: avoid serialize input value from int string to float * fix: fix ci * fix: pylint * [ML][Pipelines] avoid changing base_path in validation (#26851) * feat: add base path to path field validation error message * refactor: avoid creating temp folder when not necessary * feat: skip path validation if with additional includes * fix: pylint * fix: fix bandit * fix: resolve internal environment based on local code * Update setup.py (#26875) * [CLU] regen on 2022-10-01-preview for runtime (#26233) * regenerate on 2022-10-01-preview for CLU runtime * add rest api docs to the docstrings * remove patched docstrings for authoring, swagger transform now works to include rest api docs * use swagger transforms to edit docs instead of patch * regen runtime/authoring now that specs are in main * rerecord and fix doc * add separation between doc comment and link * Fix code snippet in README (#26879) * Migrate Attestation tests to test proxy (#26220) * Update auto-gen code for 2022-10-01-preview API version (#26873) * Update autorest code for 2022-10-01-preview API version * [Core/OpenTelemetry] Fixed spelling errors (#25610) * fix: typo, cspell config * fix: second typos * cspell: move inline to cspell.json Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * Remove mgmt azure-sdk-tools reqs ***NO_CI*** * Change default local storage location (#26891) * code and test (#26908) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Update swagger_to_sdk_config_dpg.json (#26913) * feat: enable internal components in pipeline yaml (#26800) * feat: enable internal components in pipeline yaml * refactor: add some gate logic * fix: fix test_pipeline_job_create_with_registries * fix: fix pylint * Cadl automation pipeline (#26912) * cdoe * fix * code * fix * code * meta.json * meta.json * compatible * refactor: divide pipeline related tests (#26886) * fix: sdk.ml.azure-ai-ml.tests.datastore.e2etests.test_datastore * feat: component with default label * refactor: divide test_dsl_pipeline.py * feat: load labelled arm id * feat: support name@default use name@label for node component in pipeline yaml * [TA ] improve per-document error message when all documents fail per action (#26902) * fix bad Document error message when all actions fail * update changelog * update wording * skip cosmos emulator (#26930) * try 3.7 * skip cosmos emulator tests until fixed * revert change * comment out emulator * fix ci for core (#26923) * fix ci for core * updates * updates * updates * updates * updates * adding additional version override support * update * update * update * update conda test-requirements to include azure-mgmt-storage that was previously coming dependency tools/azure-sdk-tools Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Fix py.typed verification script (#26626) In order to ensure that a py.typed file is packaged with both source and binary distributions of a package, we have a script that verifies various configurations. This script had a bug that would validate a package as passing as long as the MANIFEST.in file was correctly configured, disregarding issues in the setup.py file. This fixes the issue and updates pertinent impacted setup.py files. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [formrecognizer] Skip errors in live tests (#26649) * add more error cases to skip decorator * update last case to catch invalidimage errors * recoveryservices pin (#26935) * Add Azure DevCenter Package (#26696) * Add generated code * Add samples * Add test coverage * Recordings * Add defaults for test env variables * autorest, cspell, and shared reqs * Add readme items * Update to use testproxy * Work around issue * Update CI * Fix up tests to use kwargs * Add extra sanitizers, fix readme casing * Rerun with fresh container image * Whitelist pylint failure * Unblock * Update sdk/devcenter/azure-developer-devcenter/README.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update samples/readme * Update shared_requirements.txt Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [formrecognizer] Fix logging test to take into account new header (#26937) * allow x-ms-region to be logged * add async client * [AutoRelease] t2-resource-2022-10-18-32015(Do not merge) (#26885) * code and test * version * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * fix (#26943) * upgrade node verstion (#26944) * upgrade node * node verstion * temporality (#26924) * Fix example link (#26810) * Re-arrange imports and experimental tags to prevent warnings on unrelated operations (#26892) * change imports to avoid extra experimental warnings * add tag to merged functon * cl * add experimental tag to registry property * Remove requests dependency from PyPIClient (#26954) * remove requests dependency from PyPIClient in favor of urllib3 * update tox packaging dependency with urllib3 * add urllib3 to azure-sdk-tools requirements * [ML] Add Team Ownership Markers to Test Classes (#26957) * Add markers to test classes * add untracked changes * Change default storage retention period to 48 hrs (#26960) * azure-developer-loadtesting v1.0.0b2 (#25550) * SDK generated autorest * upload function added * patch.py changed * upload updated * whl file removed * whls deleted * aio updated * spell check added * spell check * Update shared_requirements.txt * Update MANIFEST.in Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Update setup.py Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * spell added * patch.py updated * linting corrected * Update allowed_pylint_failures.py * readme updated * patch.py updation * Update _patch.py * tests added * async naming * test and result * push the test result * fix * fix * tests added and async built * yaml added * yaml updated * sample and readme updated * fix ci.yml * more tests and samples addded and readme updated * tests * fix * fix2 * type added * type added * Update CHANGELOG.md * chnaged to developer * renamed package * chnaged ci files * linting fixes * changed namespace from analytics to developer * app_component naming cleaned * folded get_app_component * various name changes and added type hinting * lint changes * added wrapper for LoadTestClient * removed msrest dependencies * corrected Serializer method * test_smoke fixed * fixes in aio class * updates samples * namespace chg AppComponent, serverMetrics, test * updated samples * namespace changes done * LoadTestClient -> LoadTestingClient * apnd load_test to test_run & adminstration * added Readme Descirption * few changes in tests * moved SUBSCRIPTION_ID to .env * resloved readme issues by @iscai-msft in #24744 * resolved #discussion_r925248158 * resolving other issue by @iscai-msft #24744 * #25264#discussion_r925284462 * cleaned tests * namechanges * resolved folding issues * fixing dependencies verison * added tests for _patch(es) * removed subs id from recordings * fixing isodate requirements * removed SaaS key from smoke test * folder name chnage + setup.py cleaned * Readme changes suggested by @msyyc * added dependencies in shared_requirements.txt * removed os.environ from tests * liniting * removed async test * fixing tests * ci fix try * trying dev_tools * fix for azure-mgmt-loadtestservice dev_reqs * added async tests * some tests * cleaned setup * fixing async tests * added mgmt to loadtestservice to ci * changed fie mode from json to BinaryIO * reverting merge by @BigCat20196 * removed TEST_ID * solving issues by @lmazuel * update with autorest6.1.0 and update tests * update and format * fix playback failed * Update test_smoke.test_create_or_update_test_run.yaml * Update test_smoke.test_smoke_create_or_update_test.yaml * Update test_smoke_async.test_smoke_create_or_update_test.yaml * updated README * test case of app components create * delete_app_components fixed * complete testing for AppComponent Class * tested create_or_update_test * client.load_test_administration.delete_load_test * tests for get_load_test * tested upload_test_file * complete TestOperations testing * removed sas keys from recordings * corrected name error * corrected sample and added tests for test_run(1/2) * TestRun testing done * completed ServerMetrics testing * remove SAS key from files * removing SAS key * Update README.md * Update README.md * Update README.md * Update README.md * some work in tests * cleaned samples as per @ninallam * updated CHANGELOG.md * updated CHANGELOG.md * trying to fix chnagelog CI * migrate tests to testproxy * added changes suggested by @ninallam & @msyyc * updated change log * Update README.md * fixed issues with sample * fix playback failed * Update sdk/loadtestservice/azure-developer-loadtesting/CHANGELOG.md * Update CHANGELOG.md * fix playback failed * Fix changelog * Update _version.py * Update CHANGELOG.md * added bug explanation in Readme file. * removed samples and test cases from Changelog * added resource creation example in samples for mgmt plane * fixed sample resource creation link * adding ref to DefaultAzureCredential * refactor mgmt sample file * broken samples into files * fixed samples as disucssed with @iscai-msft * added few access to reult dict * update tests and recordings * Update README.md * fixed typo, matrics -> metrics * fixed typo, matrics -> metrics * update test recording * rename non test files * improved samples as per @ninallam * simplified check validation in SDK * resolved comments by @iscai-msft * pushing new design for validation checking * minor changes * removed LRO operations * minor fixes * started async tests * pushing more tests * completed corresponding async tests * removed mgmt plane samples * fixing broken link * ran black * chnaged security scope * Update CHANGELOG.md * Update conftest.py * updated README * added troubleshooting section * minor fixes Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: BigCat20196 <1095260342@qq.com> Co-authored-by: Nikita Nallamothu <50437471+ninallam@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 3790 (#26927) * Added yaml support for job matrix creation * autogen scenario matrix for stress test * Temporary Working State * update to default sparse * pr comments and some error handling * custom matrixfilename and ordering of generatedValues.yaml * common module import * JobMatrix write host Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * [EH] perf pipeline configuration (#26866) * Added EH perf resources * Added perf yml * Fix env var name * Add AZURE_EVENTHUB_NAME * Improve bicep * Align eventhub name with test-resources.json * Eliminate unnecessary variables Co-authored-by: Mike Harder <mharder@microsoft.com> * add a default of 3 retries to PyPIClient (#26963) * Resolve SSL Cert Failures in CI (#26965) * add optional ca_certs arg to urllib3 connection pool to ensure that ubuntu tests are not broken by the requests -> urllib3 swap * [ML][Pipelines] Validate invalid scenario: control flow node as init/finalize (#26918) * validate control flow node as init/finalize * fix if logic order * fix pylint issue for trailing whitespace * remove unused parameter for test * [AutoRelease] t2-elasticsan-2022-10-21-29939(Do not merge) (#26970) * code and test * generated samples Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [AutoRelease] t2-cdn-2022-10-21-12465(Do not merge) (#26971) * code and test * version * samples Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [Cadl pipeline] optimize the recording about codegen version (#26969) * version * optimization * capture details when returned (#26962) * [CLU] update sample/tests with role for conv summ (#26956) * fix how we passed in summaryAspects * skip tests and samples due to service regression * missed async * account for role * Adding code owners for ML Ops and ML Inference (#26981) * owners * owners * owners * inference owners * [Maps] Add 'include_package_data' field to setup (#26936) A recent fix to the py.typed verification script that is called in the CI now fails if the field 'include_package_data' does not exist or does not equal 'True' in a package's setup.py. This adds this file to recently onboarded packages that did not have this. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Upgrade cspell packages to version `^6.12.0` (#26985) to address dependabot issue https://github.com/Azure/azure-sdk-for-js/security/dependabot/13 Co-authored-by: Jeremy Meng <yumeng@microsoft.com> * [chore] Remove CI for unmaintained packages (#26961) ApplicationInsights and LogAnalytics date-plane packages are no longer being maintained and the nightly CI continually fail for these. Here, the CI configuration is altered to stop testing the data-plane packages. Control-plane (mgmt) package testing will still remain. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Support Model in registry in pipeline (#26914) * update * skip Co-authored-by: Ying Chen <2601502859@qq.com> * [AutoRelease] t2-cognitiveservices-2022-10-19-45579(Do not merge) (#26904) * code and test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: zhenbiao wei <424401670@qq.com> * Sync eng/common directory with azure-sdk-tools for PR 4480 (#26992) * Add extra parameters for .net readme path * Use another way for default value * Remove custom source Co-authored-by: sima-zhu <sizhu@microsoft.com> * code and test (#26996) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [ML][Pipelines] dsl.pipeline support pass non_pipeline_parameters (#26920) * support non_pipeline_parameters * fix test case * support non_pipeline_parameters * fix comment * fix code style * fix test case * fix test case * fix test case * fix comment * fix test case * fix comment * code and test (#26998) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Support identity in pipeline node (#26975) * support identity in node * add test * update * fix pylint error * fix test * [BOTRULES] ML changes (#26989) * [BOTRULES] ML changes Matching changes from #26981 * Update .github/fabricbot.json Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> * [Test Proxy] Improved logging and timeout behavior (#26903) * remove warning (#26990) * add skip flaky test decorator to FRC and FTC tests (#27010) * Split ML livetest configurations (#27009) * commit initial restructure, pushing to upstream, will stand up a single environment before merging * add unknown word to cspell list so it doesn't yell at us * [ML] Re-enable sdk logging (#26877) * Re-enable logging with opencensus * Add tests back * Fix import and change variable names * Add pylint disable for abstract class, add logger, and fix pylint error * Add check for jupyter notebook * remove comment * Move jupyter check to get_appinsights_log_handler * Move jupyter check to get_appinsights_log_handler * Update ops_logger.update_info in code and component operations * fix circular import and pylint errors * Move in_jupyter_notebook * Update docstring * Rename logger attribute to package_logger * Update OpsHandler logger attribute to package_logger * Update README telemetry section * Refactor telemetry_collection_disabled * Fix pylint * Add test for telemetry disabling * [Storage] Fix duplicate sample tag in `blob_samples_authentication.py` (#26929) * Fixed duplicate sample tag, added missing sample to async + unify samples to match more closely * Add function call to newest sample in async * Removed uncomment comment * [Storage] Merge hotfix branch into `main` (#26910) * [ML][Pipelines]test: shorten test name to enable recording (#26995) * feat: shorten test name to enable recording * fix: fix ci * Support properties in command component (#27000) * support properties * remove properties if not specified * remove properties in post dump * Separate jobs from schema load (#27019) Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Brynn Yin <biyi@microsoft.com> * code and test (#27018) Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Fix Pylint warnings for the new checkers (#26269) * Updating CODEOWNERS for common and identity (#27020) * updating codeowners for common and identity * updating codeowners with generic folder on top * fix registry managed tags (#26977) * fix registry managed tags * add testing * remove trailing whitespace * add in-line comments explaining tags * pylint pass * update swagger to match other tags exactly * Update README.md (#27027) * [ML] Add Code Owners for Split ML Test Pipelines (#27026) * [ML] Add Code Owners for Split ML Test Pipelines * fix missing entry * add scott * Update environment.py (#27005) * Update environment.py Not setting this object (environment._translated_conda_file) causes a mismatch between the registered env and the loaded one which leads to re-register the existing env. This issue only happens with environment that includes conda file. * Update sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/environment.py Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> * [Bot Rules] Update ML pull request labels (#27028) The focus of these changes is to update the pull request labels for ML paths to incorporate the changes from #27026. * [AppConfig] Fix pipeline failures (#26907) * [ML] Restrict JobServiceType to jupyter_lab, ssh, tensor_board, vs_code and perform required conversion before sending to rest API (#26863) * [ML] Validate the values of JobService.job_service_type passed to Command() and use snake_case * Fix types list * Fix tests * Update changelog.md * [Test Proxy] Documentation updates and improvements (#27036) * [Identity] Add more detail to VSCodeCred class doc (#27013) Add more details to the VisualStudioCodeCredential class docstring to let users know about its current shortcomings. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [formrecognizer] Fix readme link (#27043) * fix readme link * remove locale * Update autorest.python to `6.2.1` for new feature `--generate-sample` (#26940) * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update setup.py * optimize dependency * optimize dependency * optimize dependency * optimize dependency * [ML][Pipelines]feat: anonymous component reuse (#27008) * feat: internal anonymous component reuse - basic need to test ignore file & additional includes * fix: resolve comments * fix: fix pylint & ci * test: update internal pipeline job tests recording * fix: fix ci * fix: fix ci * fix: skip some tests in recording mode to pass ci * [NetAppFiles] T2 netapp 2022 10 14 81282 (#26978) * code and test * Update CHANGELOG.md * Update _version.py * update test recordings * update test recordings2 * update sanitizer * update test recording pool * remove commented line * update test files * add mgmt to dev-requiremetns * update test files * update test file * rerun 2 test * Update CHANGELOG.md Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Support Parallel Run Step partition by keys (#26844) * v1 * fix lint * pass through partition keys * marshal and unmarshal the partition keys in the parallel component * e2e test passed * add parallel component partition keys UT * add test case * fix UT * fix lint * fix e2e * fix UT * recording * recording twice * add comments * recording * fix recording * fix crlf to lf * skip under none live mode * update recording * fix comment * fix lint * fix ut * import json Co-authored-by: Xiaole Wen <xiwe@microsoft.com> Co-authored-by: Clement Wang <clwan@microsoft.com> * [Identity] Fix issue with cache option usage (#27030) If a user supplies `TokenCachePersistenceOptions` to a `SharedTokenCacheCredential`, these options are not used when the cache is loaded. This can lead to issues when users are trying to use caches with custom names since the default name is used instead. This commit ensures that user-provided cache options are propagated when the cache is loaded. Ref: #26982 Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Improve scenario matrix edge case handling (#27070) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Fix #26857: separate stdout from stderr in AzureCliCredential (#26953) * Fix #26857: separate stdout from stderr in AzureCliCredential * Fix unit tests for AzureCliCredential * Fix #26857 for aio.AzureCliCredential * azure_cli.py: Fix types in _run_command * Fix test_cli_credential_async.py * Update sdk/identity/azure-identity/CHANGELOG.md Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> * make registry delete return an lro poller (#26983) * make registry delete reutrn lro poller * cleanup * change operation name to begin_delete * sleep long enough to dodge ev issues in testing * move CL line to breaking changes * further refine delete swagger, edit docstrings * review comments * add reliability notice * Add test proxy setup instructions to `dev_setup.md` (#27081) * update changelog and version (#27069) * update changelog and version * Fix #26857: separate stdout from stderr in AzureCliCredential (#26953) (#27076) * Fix #26857: separate stdout from stderr in AzureCliCredential * Fix unit tests for AzureCliCredential * Fix #26857 for aio.AzureCliCredential * azure_cli.py: Fix types in _run_command * Fix test_cli_credential_async.py * Update sdk/identity/azure-identity/CHANGELOG.md Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update changelog for release (#27080) * update changelog (#26860) * update changelog * update * Fix online deployment and batch deployment documentation (#27086) Co-authored-by: Nancy Mejia Juarez <namejia@microsoft.com> * Increment package version after release of azure-ai-textanalytics (#27095) * [Storage] Migrate `test_queue_client.py` to test proxy (#27039) * Live sync finally passing * Finished async * Remove async ignore Signed-off-by: Brynn Yin <biyi@microsoft.com> Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com> Co-authored-by: Alex Tsao <alextts627@gmail.com> Co-authored-by: Maxim Rytych <99686729+maximrytych-ms@users.noreply.github.com> Co-authored-by: Aigerim Beishenbekova <aigerimb@microsoft.com> Co-authored-by: jeff-shepherd <39775772+jeff-shepherd@users.noreply.github.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Diondra <16376603+diondrapeck@users.noreply.github.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: Harneet Virk <harnvir@microsoft.com> Co-authored-by: zhenbiao wei <424401670@qq.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Daniel Ortega <96089426+danielortega-msft@users.noreply.github.com> Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com> Co-authored-by: sima-zhu <sizhu@microsoft.com> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com> Co-authored-by: Brynn Yin <24237253+brynn-code@users.noreply.github.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Matt Metcalf <mrm9084@gmail.com> Co-authored-by: Yulin Li <liyulin@pku.edu.cn> Co-authored-by: Yulin Li <Yulin.Li@microsoft.com> Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: Clement Wang <47586720+wangchao1230@users.noreply.github.com> Co-authored-by: Clement Wang <clwan@microsoft.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: David Davis <daviddavis@users.noreply.github.com> Co-authored-by: Venkat Ragavan <50309787+venkatr21@users.noreply.github.com> Co-authored-by: Han Wang <phoenix.seek@gmail.com> Co-authored-by: Pramod Valavala <43602528+PramodValavala-MSFT@users.noreply.github.com> Co-authored-by: nishuvats2009 <111009925+nishuvats2009@users.noreply.github.com> Co-authored-by: Hanchi Wang <luigiking307@gmail.com> Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com> Co-authored-by: mccoyp <mcpatino@microsoft.com> Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com> Co-authored-by: chrissmiller <chris.20@dartmouth.edu> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> Co-authored-by: Nivedit Jain <niveditjain@microsoft.com> Co-authored-by: Yashika Jain <t-yjain@microsoft.com> Co-authored-by: Yashika Jain <70585531+Yashikaj14@users.noreply.github.com> Co-authored-by: Jiefeng Chen (WICRESOFT NORTH AMERICA LTD) <v-jiechen@microsoft.com> Co-authored-by: Nivedit Jain <jain.22@iitj.ac.in> Co-authored-by: BigCat20196 <1095260342@qq.com> Co-authored-by: Nikita Nallamothu <50437471+ninallam@users.noreply.github.com> Co-authored-by: Albert Cheng <albertcheng@microsoft.com> Co-authored-by: Anna Tisch <antisch@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com> Co-authored-by: Banibrata De <banibrata@outlook.com> Co-authored-by: Jeremy Meng <yumeng@microsoft.com> Co-authored-by: Ying Chen <chenyin@microsoft.com> Co-authored-by: Ying Chen <2601502859@qq.com> Co-authored-by: lalala123123 <henu_rz@163.com> Co-authored-by: Ronnie Geraghty <rgeraghty@microsoft.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Olena Stoliarova <110589094+ostoliarova-msft@users.noreply.github.com> Co-authored-by: Muna-alhassan <63193120+Muna-alhassan@users.noreply.github.com> Co-authored-by: Man <43016276+Man-MSFT@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: TonyJ1 <41344586+TonyJ1@users.noreply.github.com> Co-authored-by: Auðunn <audunnb@gmail.com> Co-authored-by: xiaolewen <xiaole.wen@bupt.edu.cn> Co-authored-by: Xiaole Wen <xiwe@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: maowtm <micromaomao@gmail.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Co-authored-by: nancy-mejia <106106141+nancy-mejia@users.noreply.github.com> Co-authored-by: Nancy Mejia Juarez <namejia@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Jul 10, 2023
[Contoso.WidgetManager] Fix formatting (Azure#24744) - Fixes CI for Azure#24725
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Sep 23, 2023
[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-06-28-preview (#24632)
* Adds base for updating Microsoft.ConfidentialLedger from version preview/2023-01-26-preview to version 2023-06-28-preview
* Updates readme
* Updates API version in new specs and examples
* added running state and mccf update example
* added backup and restore for ledger and mccf
* updated backup restore specs
* Sync fork (#25422)
* Update readme.md for latest SDK release (#24618)
Updating tag to release official SDKs based on latest preview version
* [typespec-ci] Add pr trigger for eng/tools/TypeSpecValidation (#24640)
* Azure OpenAI: reuse LRO response model as status polling model (#24556)
* Azure OpenAI: reuse LRO response model as status polling model
* incorporate unreachable type omission for limitation of breaking change triggers
* batch rename for new LRO tack
* Updates after clarification on sync parity snap
* Update: adjustments after re-snap to plans for converged sync API
* Adjustments based on feedback and .NET viability experiments
* Example naming update (caught by CI)
* Example update
* PR feedback and re-disabling ts (will treat separately)
* [TypeSpecValidation/ Format document (#24642)
* Typespec EGv2 Clean CI (#24361)
* update to ResourceAction
* add eventgrid to ci
* example files to be added
* publishexample model after 2018-01-01
* dummyfile
* casing
* remove enum doc
Co-authored-by: Mike Harder <mharder@microsoft.com>
* add examples
* update to just be 200 responses for now
* fix warnings
* response body
* remove additional properties
* remove additional prop 2
* ran prettier
* spacing
* format
* namespace got deleted
* remove utf-8
* format
* format
* nit sample
* Add specification/eventgrid to PR triggers
* update tsp format
* add package dir to c#
* .NET still using directory-name
* update package-dir
* try without quotes like previous config
* namespace
* namespaces
* dir of V2 as in feature branch
* commenting out csharp gen
---------
Co-authored-by: Mike Harder <mharder@microsoft.com>
* [typespec-ci] Discard git changes (#24650)
- Feature was accidentally lost in the bash-to-TypeScript conversion
* adding mutability flag to the identity property ACS (#24477)
* adding mutability flag to the identity property ACS
* Updated base tag to package preview 2023-04
* fix prettier issues
* Add new stable API-version 2023-05-01 in Microsoft.Dataprotection (#24011)
* Base commit from 2023-01-01
* Change API-version from 2023-01-01 to 2023-05-01
* Add hooks changes in Microsoft.Dataprotection
* Correctness fix resProperties,rehydrationPriority
Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
* revert latest commit
* Add change for secureScore, Correctness fix resProperties,rehydrationPriority and update readme files
* Add example regarding change for secureScore
* Removing readonly secureScore from request
* Using UserAssignedIdentity from common-types definitions
---------
Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: amchandn <43201777+amchandn@users.noreply.github.com>
* update (#24655)
* [TypeSpecValidation] Enable simple-git logging (#24656)
* Add multi-vector support to search requests (#24614)
* Fixing the API-version in ManagedServices examples (#24578)
* Fixing the API-version in ManagedServices examples
* Addressing the swagger errors
* Addressing the Location header issue on Delete Registration assignment Async operation response
* [Hub Generated] Review request for Microsoft.NotificationHubs to add version preview/2023-01-01-preview (#24072)
* Adds base for updating Microsoft.NotificationHubs from version stable/2017-04-01 to version 2023-01-01-preview
* Updates readme
* Updates API version in new specs and examples
* Notification Hubs: adding API version 2023-01-01-preview
* Notification Hubs: udpating custom words
* Notification Hubs: updating custom-words
* Changing zoneRedundant (boolean) to zoneRedundancy (enum), making Network ACLs optional
* Notification Hubs: updating examples
* Notification Hubs: fixing property name
* Notification Hubs: fixing examples
* Notification Hubs: resolving some of PR comments
* Notification Hubs: adding x-ms-long-running-operation to one of Private Link operations
* Notification Hubs: removing internal MoveResourceRequest
* Notification Hubs: fixing merge marker
* Notification Hubs: fixing zoneRedundancy
* Notification Hubs: updating Swagger
* Notification Hubs: updating samples
* Notification Hubs: renaming $count to $top
* Notification Hubs: removing 200 response from PrivateEndpointConnection.Delete
* Notification Hubs: fixing async operation annotations
* NotificationHubs: suppressing linter error
* Notification Hubs: fixing async operation annotations
* Notification Hubs: fixing async operation annotations
* Notification Hubs: removing 201 for three operations
* Notification Hubs: adding back response 201 for Notification Hubs - Create or Update
* Notification Hubs: cleanup in 201 status codes
* Notification Hubs: updating ids in examples
* Notification Hubs: updating two examples
* fist add reademe.go.md (#24674)
* Updated correlationInterval example value (#24584)
* add 'location' in example parameter (#24675)
* update example parameter (#24676)
* update example parameter
* update file
* add typescript.md for new service (#24694)
* Form Recognizer v3.1 GA (2023-07-31) (#24634)
* Copy 2023-02-28-preview to 2023-07-31
* v3.1 GA changes
* Update documentation for REST docs
* Add 2023-06-01-preview for Web PubSub (#24268)
* Original commit
* Add 2023-06-01-preview for signalr and webpubsub
* remove no-op Avocado suppressions (#24703)
* Improve automation comment contents formatting (#24704)
* fix update example files for docs generation (#24710)
* fix update example files for docs generation
* fix prettier issues
---------
Co-authored-by: Joel Enikanorogbon <joelen@microsoft.com>
* FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#24716)
* Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement
Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html
Please review and merge this PR to complete the process of onboarding to the new service.
* Deleting fabricbot.json
---------
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
* Adding formatting on save for ts files (#24646)
* Adding formatting on save for ts files
* scoping to eng folder
* cleanup
* aligning prettier with typespec repo
* update tsv.ts formatting
* scoping typescript prettier to entire repo
* revert package-lock
* Added devcontainer for spec writers (#24622)
* Added devcontainer for spec authors
* Adding dockerfile
* Adding comment
* Adding convenient usage and conventions of the sdk repo path
* change MongoDbAtlasDriver name (#24709)
Co-authored-by: Zehua Chen <zehuachen@microsoft.com>
* Remove annotations (#24723)
* [Hub Generated] Publish private branch 'release-managedNetworkFabric-GA' (#24673)
* add or modify files
* Updating the readme.md
1. removing the private-preview data
* Removing the dotnet-sdk error
* Resolving the issue caused due to the backward compatibility.
* S360 Item - Missing Get SubscriptionOperations for 2021-10-01 version. (#24395)
* Resolving S320 Item - Missing Get SubscriptionOperations for 2021-10-01 version.
* Fix pipeline suggestions.
* Minor fix.
* Make Get Subscription operations sync in this version.
* Added suppress rules for failing lint errors.
* Fix suppression Issues.
* Minor fix suppression GetOperation200.
* Address minor fixes.
* Address GetOperation200 changes.
* Update readme.md: attempt suppression fix by adding ["202"] to "responses" to path
---------
Co-authored-by: Abhay Pratap <abhaypratap@microsoft.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
* add auth and fix some generated code issue in .net (#24725)
* add auth and fix some generated code issue in .net
* fixed style issue and revert property name change
* removed unused options in JS emitter
* Updated namespace value to Azure.Template
* revert examples-directory config change
* Update ci-fix cadl -> TypeSpec update (#24535)
* Update codeowners for postgresql (#24456)
Got a new team created in Azure org @Azure/azure-sdk-write-postgresql
* Add base64 formatting to contentInBase64 property (#24617)
* Add base64 formatting to contentInBase64 property
* Update base64 string
* Update base64 example string in SendEmail.json
* [Hub Generated] Review request for Microsoft.DevCenter to add version preview/2023-07-01-preview (#24291)
* Adds base for updating Microsoft.DevCenter from version preview/2023-01-01-preview to version 2023-07-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add schedule and troubleshoot APIs, add generic id property, update examples
* Add troubleshoot example and update environment examples
* Add ID to project
* Add environment operations API
* Re-add last operation ID
* Run prettier
* Add ID to delay result
* Add suppression for host parameters validation
* Remove last operation ID
* Update with aligned operations API, URI property, file type log response
* Remove old examples
* Fix naming
* Update TTL to 90 days on operations, add delete operationkind
* Add sourceType
* Remove old model
* Use an enum for status
* Consolidate on "sourceUri" for consistency with "uri" property
* Description updates
* Add NotStarted state
* Add default response and missing LRO options to resolve LintDiff warning.
* [Contoso.WidgetManager] Fix formatting (#24744)
- Fixes CI for #24725
* [Maps Search] Fix the array parameters in examples (#24658)
* Fix the array parameters in examples
* Prettier fix
* [OpenAI.Inference] Adding support for OpenAI functions. (#24534)
* Adding 2023-07-01-preview
* updating codegen
* Adding definitions for functions.
* fixes
* updates
* regenerated
* updating examples
* Updating based on some PR feedback
---------
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Travis Wilson <travisw@microsoft.com>
* [TypeSpec Validation] Move compile from "postinstall" to "build" (#24745)
- Compiling in "postinstall" breaks existing tools that copy "package.json" from repo root to spec folder
* Update Pricesheet properties for savingsPlan (#24708)
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update PriceSheet.json
* Update consumption.json
* Update consumption.json
* Update consumption.json
* Update PriceSheet.json
* elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (#24494)
* Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added PE related changes
* Added Private Link resource API
* Nit change to correct the path for privateLinkResource API
* Updated Lint errors
* prettier check
* resolved comments & added publicNetworkAccess
* removed publicNetworkAccess & NIT changes
* Updated the list operations
* resolved lintDiff
* proper value for examples and removed value from PECollections
* resolved comments
* spell check resolved
* removing volumeCreateParameter
* [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (#24390)
* add or modify files
* Updated `credentials` models according to PR #24318 + reverted unwanted changes to `readme.md`
* Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value
* Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties`
* improve NR Examples (#24636)
* improve NR Examples
* addressing AutoRun Errors
* Fixing Prettier Issue
* Adding NextLink in Max Examples
* Formatting Azure Resource Id
* Updating Format of azure subscriptionIds
* update code owner (#24754)
* Update readme.python.md (#24758)
* [TypeSpecValidation] Refactor package.json (#24756)
- Improves upon #24745
- Creates eng/tools/package.json for all EngSys tools
- Moves "postinstall" to eng/tools/TypeSpecValidation/package.json
- Technically incorrect if the package were ever to be published to a registry
- In practice, the best way I have found so far to use source-based tools in a TypeScript repo
* workflow-bot comments: update breaking changes alternative C to point to alternative B (#24770)
* [Communication] Job Router Public Preview v2022-07-18 (#23804)
* Updated JR swagger with maxNumberOfJobs
* job scheduling swagger changes
* Enforce DistributionMode.kind to be read-only
* retry with removing Required tag from abstract property for DistributionMode
* WorkerState stopped showing up in generated swagger
* Add reofferTimeUtc to decline offer API
* Prettier
* Prettier
* rename WorkerState to RouterWorkerState
* more fixes in polymorphic types
* Rename decline offer request
* prettier fix
* add example for scheduled job
* cpsell fix
* fix response schema validation error
* address review feedback item round 1
* SDK review changes
* More API changes
* Update distribution mode required properties
* Renamings
* job matching mode added
* prettier fixes
* fix examples refs
* update ref examples
* update swagger spec
* fix enum mismatch
* change operator to labelOperator in classification policy get and update ops example
* Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
* hide redundant communicationerror and communicationerrorresponse during codegen
* revert commit
* fix typo
* test whether removing kind from request works
* revert removing kind from request
* make kind read-only
* run prettier
* try adding properties to empty classes
---------
Co-authored-by: Rajarshi Sarkar 🦄 <rsarkar@microsoft.com>
Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com>
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
* [OpenAI] Rename properties for Java (#24596)
* renames
* more renames
* testing on the deploymentOrModelName
* revert for no breaking changes
* [TypeSpec] Upgrade to 0.46.0 (#24776)
* [OpenAI] Update generated autorest (#24788)
- Continuation of #24596
* Dynatrace.Observability merge to public repo (#24101)
* Initial Commit
* Updating version in all files
* Removed version from readme
* removing version which are not available from readme
* Resolving PR comments (#24205)
* Features/users/abhargava/merge to public repo (#24230)
* Resolving PR comments
* Features/users/abhargava/merge to public repo (#24233)
* Resolving PR comments
* Responding to the comment in PR review
* Fixed typo
* Features/users/abhargava/merge to public repo (#24253)
* Resolving PR comments
* Responding to the comment in PR review
* Fixed typo
* Added a suppression for Avacado issue
* Adding the required field
* Updating suppression reason
* Updating path for suppression
* Adding suppression for deprecated API
* suppression
* suppress
* Update specification/dynatrace/resource-manager/readme.md
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* updating path in suppression
* updating suppression
* updating suppression
* Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions
Iteratively work on fixing suppressions
* Update readme.md: update suppressions
* Update readme.md: update suppressions
* Update readme.md: remove Avocado suppressions
---------
Co-authored-by: kanupriyasinghh <113429657+kanupriyasinghh@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
* Double Header Fix (#24760)
* [OpenAI.Inference] Adding content filter support (#24652)
* first-pass adding annotation
* FilterResult definitions
* move Filter definitions to common
* cleaning up naming and imports
* adding version headers
* added descriptions to objects
* correct self_harm JSON projection
* Correct to "prompt_annotations"
* "prompt_annotations" for chat, too
* Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp
Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>
* Add per-choice content_filter_results to /completions
* tsp compile after merge
* recompile with 0.46.0 after today's update
---------
Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com>
* Update OpenAI PR assignment (#24794)
* Update OpenAI PR assignment
* Update pull_request_assignment.yml
* [typespec-ci] Automatically detect spec folders to validate (#24629)
* [fist] mgmt, update service name (#24781)
* [typespec-pr] Add pipeline (#24802)
* [typespec-ci] Remove path wildcard (#24804)
* Update engsys CODEOWNERS (#24808)
* Align optionality of content filter categories (#24819)
* Add spec ARM PR review workflow diagram to ARM PR description template. (#24823)
* Add spec PR review workflow diagram to ARM PR description template.
* Update control_plane_template.md: fix link to diagram (#24828)
* Added generator config for OpenAI `Functions` for the Java SDK (#24765)
* Remove repeatability support for token revocation endpoint (#24589)
* Update clientTYpe (#24503)
* [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#24048)
* Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#23832)" (#23923)"
This reverts commit e6c0e188a74d051a3a44728ce058e85447553392.
* Removed 202 and Async supression.
* Update documentation.
* Updated documentation
---------
Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
* [package-lock.json] Add names to local dependencies (#24846)
- Command "npm update" removes these names, but "npm install" adds them
- It's probably better to keep the names, since users are more likely to run "npm install"
* Update ci-fix.md: add API Doc Preview TSG (#24843)
* Update ci-fix.md: add API Doc Preview TSG
* Remove unsupported SQL Pool Rename/move operation (#24517)
* Updated text for property isSoftDeleteFeatureStateEditable (#24713)
* Updating folder structure for Microsoft.Migrate (#24550)
* folders restructure and update readme
* revert removed offazure in readme
* Removing readonly flag from top level object (#24848)
* [ACS JobRouter] Add misssing descriptions (#24842)
* Updated JR swagger with maxNumberOfJobs
* sync with upstream main
* add descriptions
* prettier fix
* add more missing descriptions
* add more description fixes
---------
Co-authored-by: williamzhao87 <williamzhao87@gmail.com>
* a couple of representation tweaks for codegen (#24847)
* Removed FunctionDefinition as custom class (#24870)
* Update readme.python.md (#24873)
* Update readme.python.md
* Update readme.python.md
* add title in typescript.md (#24879)
* Ericasp/number lookup preview (#24787)
* add isoCountryCode field (#24223)
* changed isoCountryCode description
---------
Co-authored-by: Erica <34174887+ericasp16@users.noreply.github.com>
Co-authored-by: Erica Sponsler <ericasp@microsoft.com>
* Update communicationserviceschat.json (#24845)
* update client name in typescript.md (#24894)
* update sphere ts.md (#24895)
* Convert previous preview version Private Link to GA: 2023-06-30 for mysql (#24738)
* copy previous version as base for 2023-06-30
* update api version
* update readme
* fix arm id
* Fixed code owner for NRP (#24889)
* Synapse SDK release [2023-06] (#24908)
* Anfranci/fixstartexectemplate2 (#24885)
* fix start job exec template required property
* fix start job exec template required property
* fix start job exec template required property
* SRP Swagger Updates for Jan23 [2023-01-01] Api Version GA (#23918)
* Full copy from 2022-09-01 to 2023-01-01 without any changes
* update examples api version, update swagger api version for each swagger, update readme files
* Feature: AutoUptier for LCM with example
* prettier check
* Update new deafults for allowBlobPublicAccess and allowCrossTenantReplication
* Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check
* Feature: Customer Initiated Migration with validation and prettier check
* Feature: Planned Failover with validation and prettier check
* Feature: BlobInventoryPolicyFilter creation time with validation and prettier check
* Revert "Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check"
This reverts commit 6942ddfc948f9693cd04e4768a361a6ab0607332.
* Address comments for autoUptier
* address Migration comments
* Update allowedMethods for CORS
* Revert "Address comments for autoUptier"
This reverts commit 5ac6d025ef1d2c5b5898f9e102d6f1cfa4271840.
* Revert "Feature: AutoUptier for LCM with example"
This reverts commit a1469d0b51914d11058e0cab8a7cc294e5aae761.
* remove autoUptier example
* targetSkuName description and migration name parameter
* Remove Get customer initiated migration
* Fix targetSkuName required property, fix typo
* Address lint diff new errors
* Add get migration back, fix uri for post migration
* remove query parameter from post migration
* Resolve Lint Diff errors
* Spell Chek errors
* Fix Post Migration example to return header
---------
Co-authored-by: Udit Sharma <uditsharma@microsoft.com>
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-06-01 (#24581)
* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-05-01 to version 2023-06-01
* Updates readme
* Updates API version in new specs and examples
* Hobov2 Swagger (#24471)
* Hobov2 Swagger
* fix error
* update python & java readmes (#24462)
* Bring Node os upgrade channel up GA from preview except security patch (#24487)
* bring nodeosimage up to GA except for security channel
* Update managedClusters.json
* add vpa (#24508)
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
* Allow user to specify draintimeout in ga api (#24488)
---------
Co-authored-by: Xu Xue <55420084+xuexu6666@users.noreply.github.com>
Co-authored-by: Paul Miller <paul.miller@gmail.com>
Co-authored-by: huizhifan <60024380+huizhifan@users.noreply.github.com>
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
Co-authored-by: Paul Miller <pmiller@microsoft.com>
* Release network microsoft.network official 2023 04 01 2 (#24841)
* Adds base for updating Microsoft.Network from version stable/2023-02-01 to version 2023-04-01
* Updates readme
* Updates API version in new specs and examples
* Double Header Fix (#24783)
* Add Basic sku to applicationGateway.json (#24717)
* Add http listeners alias to frontend ip config (#24718)
* Sync mode property on Load balancer backend pool (#24685)
* Sync mode property on Load balancer backend pool
* model fix
---------
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
* Migrate to IP based LB API change (#24633)
* Migrate to IP based LB API change
* Nit Fix
* NIT Fix
* Add body param pools
* Param name update
---------
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
---------
Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
Co-authored-by: russsantos <127546568+russsantos@users.noreply.github.com>
Co-authored-by: anjbal <137822143+anjbal@users.noreply.github.com>
Co-authored-by: unknown <anjbal@DESKTOP-ML6T5PL.redmond.corp.microsoft.com>
* Adding new APIs for billing visibility in new version 2023-07-01-preview for Microsoft.Elastic (#24587)
* Base API Commit
* Changing API version to 2023-07-01-preview
* Adding new apis for billing visibility
* updating readme.md
* added partnerEntityUri in the response
* model validation fixed
* taking parameters from v5 common types
* [typespec-ci] Improve change detection (#24825)
- Fixes #24813
- Fixes #24818
* [typespec - pr] Validate all specs if any changes to common files (#24826)
- Fixes #24814
* [typespec-ci] Disable PR trigger (#24920)
* Storage STG 90 (#24915)
* Added new version of Data Lake swagger (#23905)
* Added new Files swagger (#23907)
* Paginated Directory Delete (#24146)
* mgmt, java, azurestackhci, dedup name "Update" (#24924)
* update parameter name in selfhelp sample (#24928)
* Update TypeSpec get started guide (#24901)
* Update TypeSpec get started guide
* Update documentation/typespec-rest-api-dev-process.md
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
---------
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#24678)
* Adds base for updating Products from version preview/2023-01-01-preview to version 2023-05-01-preview
* Updates readme
* Updates API version in new specs and examples
* 2023-05-01-preview version
* fix locations
* fix readme
* fix validations 1
* fix RAM
* Add has RI
* Remove dynamic page size query param
* Refactor operation id
* Fix readme
* Fix products operation id
* Documentation fix 1
* Documentation fix 2
* Documentation fix 3
* spell check fixes
* prettier fixes
---------
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* [Get-TypeSpec-Folders.ps1] Sort output alphabetically (#24932)
* [Validate-TypeSpec.ps1] Add GitClean switch (#24933)
- Continuation of #24629
* [Hub Generated] Publish private branch 'RPSaaSMaster' - NetworkCloud 2023-07-01 stable API (#24722)
* add or modify files
* removed non-published old private preview
* New stable api 2023-04-01 Microsoft.RedHatOpenShift (#23772)
* Previous API version
* New API 2023-04-01
* Fix swagger linting error
* Added xmsEnum for OutboundType
* Re-word description for OutboundType
* Microsoft.OperationalInsights: Correcting Total retention in days limitation. (#24574)
* OperationalInsights: 2022-10-01 stable version
* Actual changes.
* More fixes.
* more changes.
* Removing redundant breaking change.
* Workspace identity: referencing standard types.
* Referencing managed identity standard type, refactoring booleans into enum.
* Fixing examples.
* Removing duplicate resource.
* Update Workspaces.json
* Update Clusters.json
* Revert "Update Clusters.json"
This reverts commit 4eb99cf4699afeb95dc2bab1ee071c7d4f9ee2c5.
* Revert "Update Workspaces.json"
This reverts commit c16bc82f2ec8a35131c1ec54d2dca147eca929d1.
* Returning to our identity implementation.
* OperationalInsights 2022-10-01: Changing retentionInDaysAsDefault to boolean representation.
* redundant comma.
* redundant comma.
* Adding missing example header.
* Update TablesDelete.json
* Microsoft.OperationalInsights: Correcting Total retention in days limitation.
* config reademe.go.md (#24941)
* config reademe.go.md
* format
* [Hub Generated] Publish private branch 'main' (#23608)
* add swagger
* updated swagger
* Updated readme for Unified Vision Service
* fixed build error
* update api version
* fixed typo
* update comment
* Add examples
* fixed
* prettier
* add custom word
* Address some comments
---------
Co-authored-by: KUAN LU <kualu@microsoft.com>
* Changing operation name to match other related API for documentation (#24588)
* Update computeRPCommon.json (#24910)
* add directive mobilenetwork reademe.go.md (#24942)
* sql readme.go.md directive (#24610)
* sql readme.go.md directive
* rename to ServerPrivateEndpointConnectionProperties
* lenient-model-deduplication
* Saifahmed098 databoxedge microsoft.data box edge 2023 07 01 (#24926)
* Adds base for updating Microsoft.DataBoxEdge from version stable/2022-03-01 to version 2023-07-01
* Updates readme
* Updates API version in new specs and examples
* Adding string KubernetesWorkloadProfile in databoxedgeProperties
* Update readme.python.md (#24980)
* Update readme.python.md
* Update readme.python.md
* [ACS - Call Automation] [Beta2] Api spec for 2023-06-15-preview (#24482)
* Add beta2 api spec
* add readme
* fix lines
* Fix readme
* Added repeatability
* Fix 202 long running
* Fix header
* Fix the base
* Fix check
* added x-ms-long-running-operation
* add location
* fix example
* test
* test
* test
* fix
* test
* fix test
* test
* Fix
* test
* test
* fix
* Remove LRO
* Updates as per ARB feedback
* Updates as per ARB feedback
* Fix senddtmfTones
* Fix error
* Fix send dtmf description
* Update/remove obsolete docs (#24946)
* Add openapi docs for OpenAI api version 2023-07-01-preview (#24992)
* rename EdgeZoneStorageAccountType back to StorageAccountType to avoid breaking (#24988)
* Adding new optional parameter to Auto Patching (#24554)
* [TypeSpec Validation] Get-TypeSpec-Folders.ps1 should only validate all specs on selected files (#25010)
- Fixes #25006
* Update readme.python.md (#25009)
* Update readme.python.md
* Update readme.python.md
* [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#25014)
* Documentation fixes
* Documentation fixes 2
* Documentation fixes 3
* Documentation fixes 4
* Documentation fixes 5
---------
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* fix enum mismatch (#24559)
* Moving Markup rules API into separate file (#25003)
* [ACS Chat] [Rest API] Added chat thread metadata and participant meta… (#24837)
* [ACS Chat] [Rest API] Added chat thread metadata and participant metadata. (#24243)
* Updating ACS Chat swagger with Chat thread and participant metadata.
* Fixed swagger version.
* Fixed swagger version.
* Re-added data retention policy to the swagger.
* Update communicationserviceschat.json - changed metadata from string to dictionary
* Update communicationserviceschat.json
* Update communicationserviceschat.json
Corrected size limitations - should be 1k, not 2k
* Update communicationserviceschat.json
Added metadata to patch thread request
* Update communicationserviceschat.json
---------
Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com>
* remove data retention from 2023-07-01
---------
Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com>
Co-authored-by: Lu Chen <luc@microsoft.com>
* Added missing ArchiveStatus value (#25024)
* Update PrivateEndpointConnections to 2022-11-01-preview in v5 SDK (#25015)
* sql readme.go.md directive (#25029)
* sql readme.go.md directive
* fix
* [TypeSpec Validation] Rename yml files to match pipelines (#25036)
* Update readme.python.md (#25035)
* Disable creation of perimeter base rule (#24945)
* Disable creation of perimeter base rule
* Made NSP rule readonly
* Added email/sms rule changes
* Minor fix
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-06-02-preview (#24922)
* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-05-02-preview to version 2023-06-02-preview
* Updates readme
* Updates API version in new specs and examples
* Hobov2 Change Swagger Preview (#24472)
* Hobov2 Swagger
* fix error
* Add SSHAccess property to agent pool (#24460)
* Add SSHAccess property to agent pool
* add new line
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
---------
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
* update python & java readmes (#24461)
* Image Integrity swagger in 20203-06-02-preview (#24454)
* Image Integrity swagger in 20203-060-20-preview
* f
* f
* ff
---------
Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com>
* Azure Service Mesh - BYO CA, Egress Gateway and Mesh Revisions (#24453)
* Azure Service Mesh - BYO CA and Egress Gateway
* prettier fix.
* adding changes for for revisions and meshversioncompatibilityprofile
* adding a missing parameter
* Changes as per lint failures
* Mikolaj/add custom node config 2023 06 02 preview (#24539)
* feat: add Ulimit config and updated sysctl ranges to swagger
* fix: use ulimits in json of LinuxOSConfig
* feat: add response example
* fix: add ulimits to custom words
* Revert "fix: add ulimits to custom words"
This reverts commit 949673772bb77447d5b3975ea5da27767c9705e2.
---------
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* add Drain Timeout in preview (#24579)
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
* fix: remove ulimits from swagger spec (#24921)
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* address ARM review comments (#25005)
* address ARM review comments
* added a missing description.
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
---------
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
---------
Co-authored-by: Xu Xue <55420084+xuexu6666@users.noreply.github.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Xinhe Li <xinhl@microsoft.com>
Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com>
Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com>
Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com>
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
* [Hub Generated] Add new api version 2023-05-01 for Microsoft.App (#24939)
* Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-01
* Updates readme
* Updates API version in new specs and examples
* Revert AppGw HttpListeners alias change (#24966)
* [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-06-01-preview (#24426)
* Adds base for updating Microsoft.ContainerRegistry from version preview/2023-01-01-preview to version 2023-06-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added new api version 2023-06-01-preview
* Fixed examples
* Fixed Prettier check.
* Fix lint error.
* fix pretty print
* Try fix avacodo error
* Fix the default tag
* add directive in readme.go.md
---------
Co-authored-by: Alancere <804873052@qq.com>
* [Hub Generated] Publish private branch 'u/michaelshikh/azure-kusto-Microsoft.Kusto-2023-05-02' (#24964)
* kusto 2023-05-02 fix "final-state-via" header
* take 2
* remove "x-ms-long-running-operation-options"
* remove "x-ms-long-running-operation-options"
* Release sentinel 2023 07 01 preview (#24557)
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-06-01-preview to version 2023-07-01-preview
* Updates readme
* Updates API version in new specs and examples
* Added Approved and Backlog to Hunts Status enum (#24552)
* [Sentinel] [New Public API] Add swagger doc for dataConnectorDefinition API (#24509)
* add dataConnectorDefinition API doc
* update examples
* add pattern
* update pattern
* update pattern
* update description
* update description
* small fix
* small fix
* small fix
* small fix
* update swagger document based on feedback from the SDK team (#24555)
* Fix dataConnectorDefinition (new API) (#24759)
* fix swagger doc
* typo
* fix int format
* Fix pattern (#24807)
* remove pattern
* add and fix - reuired parameter in the new validation
* add and fix - reuired parameter in the new validation
* fix pattren
* fix pattren
* Remove CloudError.cs file (#24962)
Remove CloudError.cs. Added by mistake in https://github.com/Azure/azure-rest-api-specs/pull/24807/files
* Add pagination (#24986)
* add pagination
---------
Co-authored-by: artafres <94412144+artafres@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
* Update documentation for Cost Details to specify Resource group and management group is not supported (#24844)
* Update readme.python.md (#25055)
* [Hub Generated] Review request for Microsoft.Management to add version stable/2023-04-01 (#24976)
* Adds base for updating Microsoft.Management from version stable/2021-04-01 to version 2023-04-01
* Updates readme
* Updates API version in new specs and examples
* [Hub Generated] Review request for Microsoft.LabServices to add version stable/2023-06-07 (#24981)
* Adds base for updating Microsoft.LabServices from version stable/2022-08-01 to version 2023-06-07
* Updates readme
* Updates API version in new specs and examples
* added v2023-06-07 spec
* reset clouderror change
* update version date
* updated times
* fix times in examples
* update inviteuser example
* reinclude x-mx-identifiers
* Update for Swagger PrettierCheck
* TLS Default version updated to enforce TLS 1.2 (#24440)
Co-authored-by: Daniel Salazar Mora <dsalazar@microsoft.com>
* Update the ARM spec PR review workflow diagram (#25071)
* update python config (#25074)
* Add MicrosoftProduct to ProductType enum (#25046)
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* Initial version of the code-signing dataplane service (#22310)
* Initial version of the code-signing dataplane service
* Remove error objects since those come from the Azure Core namespace
* fix: added azure.codesigning.json resulting file
* fix: use newer version dependency syntax
* Rolling back version change per PR feedback
* fix: polling operation mapping per PR feedback
* Adding x-ms-examples for example validation
* fix: added custom-words per PR feedback
* Renamed parameter definition to match open api json definition
* fix: modified the api-version to synch up with the folder api-version
* Adding details json cadl validation
* refactor: moved from cadl to typespec
* chore: attach azure.codesiging.json definition
* chore: remove package-lock.json since its unneeded.
* feat: adding get sign eku operation & example
fix: sign long running operation
* chore: removed unused swagger.json generated
* chore: removing data-plane swagger generated, keeping just the typespec project
* Readding the swagger information for dataplane service
* fix: ci issues pointed
examples are not referenced on the swagger file
resources should not be read only
* added examples to typespec definition
* fix: examples
* more fixes for example.json operations
* even more fixes for example.json operations
* fix: minor
Remove optional parameter from region. since its required.
Added description to namespace definition
Removed optional parameter from operation status, since the id is required.
Added suppression of warning
* Added fixes to azure.codesigning.json generation
* Added required property of id to examples
* Switched property to a more descriptive naming for the eku response
* fix: moved examples to a non version specific folder
* fix: the compiler didnt liked not using the preview folder, rolling back
* feat: added oauth2 security definition
* fix: removed api-version from example path
* style: change casing of operations to camel case
fix: per guidance modified the getsignEku operation into listSignEku
* Update azure.codesigning.json generated by tsp compiler
* fix: modified ResourceAction to LongRunningResourceAction per feedback
* docs: added enum descriptions to each value on hash algorithms
* fix: pinned to current versions to avoid ci errors by using latest dependency
* Added prefix of StandardResourceOperations interface to Resource operations
* fix: sign operation should return 202 Accepted on example
* fix: sign operation should return 202 Accepted on example
* style: tsp format result
* refactor: removed unused mapping to parent resource
* refactor: removing typespec-python emitter
* Adding get sign root certificate operation
* fix: adding custom word rootcert
* fix: adding api version parameter
* Added resource provider folder per ci finding
* chore: removing package.json per PR feedback
* Renaming folder to remove "Microsoft." path per feedback from PR
see: https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/typespec-structure-guidelines.md for guidelines
* feat: expanded the typespec options to include the lang generation
* Fix: Based on review from API stewardship team
Added more detailed information for docs and summary of operations
Refactored getSignRootCertificate operation to use RpcOperation instead of custom operation
Pluralized the listSignEkus operation
Renamed models to provide more detailed description of their purposed
Eliminated the custom enum in favor of the typespec enum provided
* refactor: moved version to 2023-06-15 based on feedback of ACS Eng team
* refactor: renamed models following azure team feedback
* Update tspconfig.yaml
Applied latest schema of emitter options and parameters.
* fix: adding back missing custom words, fixing coffeelake casing
* docs: updated samples to include varied hashes to represent a more familiar request for customers
* docs: updated the docs clauses of the typespec file to avoid repetitions on the docs generated.
* fix: update README.md of data-plane generation to include the correct tag
* Regenerated azure.codesigning.json file
* Based on pr build feedback, updated custom words definition
* docs: per compiler feedback, adding doc definition for versioning
* fix: outdated examples of data-plane swagger
* fix: per PR feedback, using T payload for Foundations.OperationStatus
* chore: updated Azure.CodeSigning swagger generated using tsp v0.46.0
* fix: removed autorest from the dependencies per feedback
fix: added suppression for custom RPC operation
* Removing json examples for compliance with avocado pipeline
* fix: Adding examples to tsp directory
* Corrected samples
---------
Co-authored-by: Ray Chen <raychen@microsoft.com>
* [Bug-Fix] Minor change in Managed Network Fabric (#24948)
* Changes Made:
1. InternetGateways - type param is renamed to gatewayType
2. NetworkFabricSkus - type param is renamed to skuType
3. AccessControlLists:
-> action -> type is renamed to actionType
-> matchcondition -> ipmatchCondition -> type is renamed to ipType
4. NetworkTapRule
-> action -> type is renamed to actionType
-> matchcondition -> ipmatchCondition -> type is renamed to ipType
New Params:
1. In RoutePolicies: -> statements -> defaultAction [Permit | Deny -> default Deny] is added.
2. In RoutePolicy -> condition -> conditionType is added.
3. In AccessControlLists: -> matchConfiguration -> defaultAction [Permit | Deny -> default Permit] is added.
* Reverting the changes made for "type" parameter.
* Add Microsoft.StorageTasks Service | Swagger API Review (Ring 0 Service) (#24798)
* Add the Readme files and StorageTasks Spec file with CRUD and List by subs and rg with examples
* Rectify provider namespace to Microsoft.StorageTask and refactor examples into folders
* Address Lint diff failure to use the model from common-types
* Update Operations API with defaut response
* Add List Storage Task Assignment ARM Ids API
* Add POST List Storage Task Run Report Summary API
* Adding x-ms-identifiers
* Spell corrections
* Fix spell check errors
* Add 201 response code to PUT task operation
* Address minor changes and comments to reuse existing schema, update examples
* Add request body to List Summary Report API, Add Example. Remove 200 status code from Delete Async
* Add example reference to API file
* Adding Storage task action preview API with example
* Correct spelling
* Addig allowed resource type constraint
* Change the Reporting API to GET with Arm resource type Microsoft.StorageTasks/storageTasks/reports
* Address PR comments, correct and rephrease operation ids
* Change to proxy resource
* Fix typo
* Better instructions in footnotes for the ARM spec PR review workflow diagram (#25076)
* Updated request models for R2026 issue agrifood microsoft.ag food platform 2023-06-01-preview (#25057)
* Adds base for updating Microsoft.AgFoodPlatform from version preview/2021-09-01-preview to version 2023-06-01-preview
* Updates readme
* Updates API version in new specs and examples
* Rename changes + Control Plane BYOL changes
* added examples
* added examples for data Connector Apis
* fixing lint issues
* reorder and updated description
* node description updated.
* updated like Solution Apis
* beautify json examples
* prettier fix
* custom words + spelling fix
* system data lower case
* removed dataConnectorName from example + lint fix
* fixed lint issue in example
* prettier fix
* Default Error response + 201 code
* Description updated
* request model made same as response in patch
* added status code 201 in PUT API
* updated solution example
* updated changes for OAuth renaming
* updated Data Connector examples
* example update
* corrected typo
* syncing to latest DI Agri branch
* added MADMA in custom-words file
* data connector delete example updated
* solution example updated
* xms error fix
* added xms-identifier
* fixing examples
* updated create or update example
* prettier fix
* solution fix
* updated examples
* prettier fix
* lint issue fix
* fixing lint diff
---------
Co-authored-by: Abhishek Khatri <akhatri@microsoft.com>
* privateEndpointConnections and privateLinkServiceConnectionState naming fixes (#24810)
* Add comment handler for /pr RequestMerge (#25091)
* Sync expression Support From DataFactory To Synapse (#25054)
* Sync expression Support From DataFactory To Synapse
* add
* Update the ARM PR workflow diagram to use the `/pr RequestMerge` guidance. (#25093)
* Improve ARM PR template and guidance around breaking changes (#25086)
* [Hub Generated] Review request for Microsoft.Maps to add version stable/2023-06-01 (#23862)
* Adds base for updating Microsoft.Maps from version preview/2021-12-01-preview to version 2023-06-01
* Updates readme
* Updates API version in new specs and examples
* updates to schema
* move to v4 as managedidentity is broken in v5
* fixes from build
* fix example
* reuse trackedresource v2
* adding suppression for move
* trying to suppress with from
* attempt 3 for supression based on cogsearch
* Updating ContainerStorage Swagger (#24749)
* updating containerstorage to match Azure-ContainerStorageRP swagger
* updating readme.md files
* removing disks in example request and adding an extra zone to examples
* updating examples
* Add new API version 2023-03-01 for databox (#24857)
* initial commit - previous version
* add new version
* add new version in readme
* fix validation checks
* fix readme file
---------
Co-authored-by: Uttaran Sarkar <utsarka@microsoft.com>
* Update readme.python.md (#25136)
* [package.json] Remove cadl packages (#25141)
- Any specs still using Cadl must upgrade on next change
- Fixes #25126
* Add ConfiguringAAD as a provisioning state (#25079)
Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com>
* [CODEOWNERS] Add selected root files to EngSys (#25143)
* [HDInsight][Hilo]Add new APIs (#24940)
* Add new APIs
* Fix spell, modelvalidation and avocado errors
* fix false alarm linting error
* Fix linting error
* Add readme files under hdinsightonaks folder
* Update json file path
* Update readme.python.md
* a) update job related definition
b) update some resource id property to use
c) update key vault object type as enum
* mark cluster pool compute profile count as readonly
* remove wrong avocado suppress fro readme.md per comment
---------
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* [TypeSpec Validation] Trigger on PRs to all branches (#25174)
* Add missing space (#25153)
Co-authored-by: Oren Kafka <orkafka@microsoft.com>
* Added lro-options for dataprotection 2023-01-01, 2023-05-01 (#24715)
Co-authored-by: Vishesh Patel <133762830+vishesh155@users.noreply.github.com>
* TypeSpec Getting Started doc (#25021)
* TSP Getting Started
* update
* updated doc
* updated doc
* moved how to create PR from TypeSpec doc to rest-api-spec repo
* updated per PR comment
* AVS API 2023-03-01 (#24490)
* cp -r 2022-05-01 2023-03-01
* set version as 2023-03-01
* changes
* switch back to v1 ErrorResponse
* must not use two differert ErrorResponse types
* use v5 ErrorResponse (#4)
* remove sku changes
* #/definitions/Sku
* remove old readme block
* remove skus.json
* add patterns for resource names
ported from https://github.com/Azure/azure-rest-api-specs-pr/pull/11127
* Update readme.python.md (#25195)
* Update readme.python.md (#25078)
* Update readme.python.md
* Update readme.python.md
* [Hub Generated] Review request for Microsoft.HybridCompute to remove version preview/2023-04-25-preview (#24970)
* update name pattern and change instanceview
* update examples
* add ExtensionsResourceInstanceView
* change extensions instance view
* undo ref change
* update times in examples
* Remove 04-25-2024 from the public specs repo. Will add these specs to the private repo
* Update readme.md
* Update readme.md
---------
Co-authored-by: Ved Kale <vedkale@microsoft.com>
* [Compute] New API Version 2023-04-02 (#25118)
* adding new folder 2023-04-02
* readme section for 2023-04-02
* changing version number in folder 2023-04-02
* Adding new disk property - LastOwnershipUpdateTime (#25039)
* Added lastownership field
* Added to existing DIsk_Get.json example
* Swagger changes for elastic san import and export feature (#24953)
* swagger changes for elastic san import and export feature
* fixing API version in swagger examples
* adding reference to examples
* fixing examples
* Dev/carloshehe/last ownership update time (#25160)
* Added lastownership field
* Added to existing DIsk_Get.json example
* New description
* Using Vikram's suggestion for description
* Fixed bad casing
---------
Co-authored-by: carlos6125 <140001684+carlos6125@users.noreply.github.com>
Co-authored-by: PrambMS <136007667+PrambMS@users.noreply.github.com>
* New AO5GC 1.0 service - 2023-05-15-preview (#24950)
* New AO5GC 1.0 service - 2023-05-15-preview
* Addressed the Swagger LintDiff errors
* Addressed the Swagger ModelValidation errors
* Addressed long running operation LintDiff errors
* Formatted the *.tsp files
* Removed the common.json and added the parameters to the networkfunction.json
* Updated the Type Script to address the Swagger API validations
* Addressed the validation errors
* Updated the examples and formatted the *.tsp files
* Update specification/mpcnetworkfunction/resource-manager/readme.typescript.md
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
* Update specification/mpcnetworkfunction/mpcnetworkfunction.Management/tspconfig.yaml
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Updated the common types version to v3
* Updated the networkfunction TypeSpec file to the latest version and generated the Swagger API
---------
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
* [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-07-01 (#25151)
* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-06-01 to version 2023-07-01
* Updates readme
* Updates API version in new specs and examples
* feat: add range min/max for custom node config GA changes for 2023-07-01 API (#25068)
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
* update readmes (#25048)
* add force upgrade option (#25100)
* add force upgrade option
* update msg
---------
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
---------
Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com>
Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com>
Co-authored-by: Wenjun Gao <wenjungao@microsoft.com>
* [TypeSpec Validation] Only validate all specs on core PRs to public repo (#25207)
- Fixes #25175
* Use unix line endings always, even on Windows (#24817)
- Fixes #24791
- Fixes #24790
- Ensures developers can successfully work on both Linux and Windows
- Consistent with other repos like `microsoft/typespec` and `azure/azure-sdk-for-js`
- Required for node-based tools like `tsp format` which assume LF
* Synapse change sessionId type from int to string (#25210)
* change sessionId type from int to string
* modify related code
* [TypeSpec] Upgrade to 0.47.0 (#25223)
* Renormalize line endings from CRLF to LF (#25219)
- Fixes #25212
- Files were committed with CRLF instead of LF
- Should be prevented going forward due to settings in `.gitattributes`, but clients can always force add files with CRLF
- Related to #24817
- Issue seen before in #4746 and #3786
* config readme.go.md (#25227)
* July 2023 API Version for Azure Data Manager for Agriculture (#24755)
* added july 2023 api version
* fixed few changes
* Prettier
* Avocado
* Updated examples
* fixed examples
* added changes
* addressed review comments
* addressed review comment
* fixed build issue
* fixed model validation error
* addressed comment
* addressed review comments
* few minor changes
* added minor changes
* prettier
* addressed review comments
* `securitycenter`: fix yaml (#24619)
* `securitycenter` fix yaml
* fix path in readme.md
* remove kubevirt and openstanck (#25094)
* [AutoSync] db0c25231 Merged PR 8381862: update manifest (#25034)
Co-authored-by: swagger-automation <swagger@microsoft.com>
* [Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2023-07-07-preview (#24747)
* Adds base for updating Microsoft.DesktopVirtualization from version preview/2022-10-14-preview to version 2023-07-07-preview
* Updates readme
* Updates API version in new specs and examples
* Added ScalingPlanPersonalSchedule examples to Examples
* Added scalingPlanPooledSchedule endpoints to swagger
* Added flexAppGroup to public preview
* Added scalingplanpersonalschedules endpoint to proper swagger version
* Added showInFeed property to correct swagger version
* Added missing scaling plan personal schedule
* Added pattern
* Removing pattern restriction as it causes breaking changes
* Corrected api version in example
* change new scaling API to use v3 common types
* Added pattern
* Removed pattern and added suppression.
* Revert "change new scaling API to use v3 common types"
This reverts commit a169c4031f253b54172a4b5271f0f8290db8d7de.
---------
Co-authored-by: Dallin Magleby <damagleb@microsoft.com>
* CRP 2023 07 01 version (#25066)
* add new folder
* update readme
* update version reference in swagger files
* psuh
* revert last commit
* Add missing parameter(timeCreated) in VMSS VM (#23848)
* Updating examples for GetImages API to add details about paging.. (#24030)
* Updating examples for GetImages API to include the paging support.
* Addressing PR comments. Added the a template for next link
---------
Co-authored-by: Naveena Patil <napatil@microsoft.com>
* Add optional parameter domain name label scope to VM and VMSS PIP dnsSettings (#24329)
* add optinal parameter domain name label to vm and vmss pip dnssettings
* fix syntax
* fix syntax
* fix syntax
* changes made by prettier
* Update Image_ListBySubscription.json
prettier
* update diskRP reference to latest. Merge conflict.
* credscan remediation
* Adding support for Sirius on VMSS (#25117)
* adding auxmode and auxsku
* adding example
---------
Co-authored-by: Prachi Pravin Bhavsar <prbhavsar@microsoft.com>
* missed ticks from conflict merge
---------
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: payalguptapg <126145083+payalguptapg@users.noreply.github.com>
Co-authored-by: nreact <43445179+nreact@users.noreply.github.com>
Co-authored-by: Naveena Patil <napatil@microsoft.com>
Co-authored-by: tinama0302 <79952980+tinama0302@users.noreply.github.com>
Co-authored-by: pracsb <78512712+pr-work@users.noreply.github.com>
Co-authored-by: Prachi Pravin Bhavsar <prbhavsar@microsoft.com>
* Update control_plane_template.md: update merge queues links (#25231)
* Added artifactType query param to listkeys route (#24868)
Co-authored-by: Sai Sankar Gochhayat <sgochhayat@microsoft.com>
* [Hub Generated] Review request for Microsoft.ConnectedVMwarevSphere to add version preview/2023-03-01-preview (#25147)
* Adds base for updating Microsoft.ConnectedVMwarevSphere from version preview/2022-07-15-preview to version 2023-03-01-preview
* Updates readme
* Updates API version in new specs and examples
* Merging new API version from private pr repo
https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware/resource-manager/Microsoft.ConnectedVMwarevSphere/preview/2023-03-01-preview
* fix lint errors
* fix json
* fix more lint errors.
* update
* update
* fix lint errors
* prettier and fix examples.
* fix quotes.
* Release microsoft.app 2023 05 02 preview (#25051)
* Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-02-preview
* Updates readme
* Updates API version in new specs and examples
* fix description for endTime in JobExecution (#24359)
* fix description for endTime in JobExecution
* fix for breaking change error
* Introduce Microsoft.App/builders tracked resource and Microsoft.App/builds proxy resource (#24240)
* cherry picked commit to introduce builders and builds, and updated api version
* added linting suppressions to readme
* pre feedback: v3 -> v5, common build/er params, rename identity to identityresourceid, inprogress -> creating
* fix typo
* fix model validation
* added updating provisioning status, and fixed a missed provisioning status ref
* Create identity to registry mapping in builder object (#24275)
* create identity to registry mapping in builder object
* update mapping to be a dictionary of container registries, to enforce single container registry
* run prettier
* run prettier on examples fil
* pr feedback: v5 -> v3 and added x ms param location
* fix plural naming to singular
* Add GetVerificationId API (#24286)
* add api
* fix typo
* fix spacing
* fix spacing
* change version
---------
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
* Support multiple port for container app (#24332) (#24459)
* Support multiple port for container app
* lint
* comment
* Add blob storage token store support (#24455)
* add blob storage token store support
* update
* update trigger type enum - schedule for jobs (#24399)
* update trigger type enum - schedule for jobs
* update trigger type enum - schedule for jobs
* add previous changes merged to main
* add encryption settings (#24822)
* rename verification id to custom domain verification id (#24874)
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
* Removed SourceToCloud feature from 2023-05-02-preview (#24860)
* Anfranci/fixstartexectemplateabv0423 (#24863)
* fix start job exec template required property
* fix start job exec template required property
* fix start job exec template required property
* fix start job exec template required property
* Add list usages api for Microsoft.App (#24833)
* add api
* update
* update
* update
* update
* empty line
---------
Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
Co-authored-by: anandanthony <anfranci@microsoft.com>
Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com>
Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
* add dbName as required for spark metastore (#25259)
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
* the java sdk doesn't use that config (#25214)
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
* Alprosms cost management microsoft.cost management 2023 08 01 (#25065)
* Adds base for updating Microsoft.CostManagement from version stable/2023-03-01 to version 2023-08-01
* Updates readme
* Updates API version in new specs and examples
* Adding GA for ReservationUtilization Budgets from version 2023-04-01-preview
* updating swagger spec to new api version
* adding x-ms-parameter-method property to budgetCategoryFilterParameter
* Release keyvault mi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK is being regenerated based on a new swagger spec and the upload file function has been written.
cmd: