pin markupsafe #23132
Merged
pin markupsafe #23132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
requested review from
scbedd,
weshaggard and
benbp
as code owners
scbedd
approved these changes
Feb 18, 2022
This was referenced Feb 24, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits) pin markupsafe (Azure#23132) [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116) Add timeout on Invoke-request call (Azure#23120) Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115) Update aggregate-report to use common credscan yml and update baseline file (Azure#23090) Update CHANGELOG.md (Azure#23119) [Issue helper] Update owner list (Azure#23079) [KV] Update changelogs for stable releases (Azure#23053) code and test (Azure#23047) [recoveryservicesbackup] fix multiple pages paging (Azure#23089) rerecord failing tests for fr (Azure#23107) [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113) [Storage] Fix some mypy typing errors and typing imports (Azure#23098) Add logic to generate docs.ms ToC (Azure#23086) Fix broken link in tests.md (Azure#23110) Enable apistub gen step (Azure#23088) pin version of storage blob used for testing (Azure#23109) ensure that py36 can start the process properly (Azure#23108) fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085) code and test (Azure#23077) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
* pinning markupsafe to version 2.0.1 everywhere. py2 version is pinned to 1.1.1 Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing this in the CI: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1377829&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=651a14cc-88df-515d-1311-e0e8b23b578a&l=1078
We take a dependency on jinja2 which takes a dep on markupsafe. It seems markupsafe released yesterday and introduced breaking changes. Trying to pin to the older version to see if it resolves CI.