Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update new app service api version #23034

Merged
merged 10 commits into from
Mar 3, 2022
Merged

update new app service api version #23034

merged 10 commits into from
Mar 3, 2022

Conversation

xiangyan99
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Identity label Feb 11, 2022
chlowell
chlowell reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServiceCredential should read IDENTITY_ENDPOINT and IDENTITY_HEADER instead of MSI_ENDPOINT and MSI_SECRET. You can delete MSI_SECRET and _parse_app_service_expires_on(). They're needed only for 2017-09-01.

sdk/identity/azure-identity/tests/test_managed_identity.py Outdated Show resolved Hide resolved
sdk/identity/azure-identity/tests/test_managed_identity.py Show resolved Hide resolved
@xiangyan99 xiangyan99 requested a review from chlowell March 3, 2022 00:53
xiangyan99 and others added 4 commits March 3, 2022 09:24
@xiangyan99 @chlowell
Update sdk/identity/azure-identity/tests/test_managed_identity.py
e94a7cf 
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
@xiangyan99 @chlowell
Update sdk/identity/azure-identity/tests/test_managed_identity.py
a21990c 
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
@xiangyan99 @chlowell
Update sdk/identity/azure-identity/tests/test_managed_identity.py
75f383f 
Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
@xiangyan99
update
c33e781
@xiangyan99 xiangyan99 requested a review from chlowell March 3, 2022 18:04
@xiangyan99 xiangyan99 merged commit 74a192a into main Mar 3, 2022
@xiangyan99 xiangyan99 deleted the identity_new_app_service_version branch March 3, 2022 22:16
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
b042273 
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (92 commits)
  [Mgmt Compute] Sanitize recordings (Azure#23331)
  [Tables] Release prep (Azure#23297)
  [Cosmos] move system_key logic to query_iterable (Azure#22893)
  [Cosmos] added additional warning to default consistency change (Azure#23225)
  update template (Azure#23333)
  [Storage] Address comments from API Review for March release (Azure#23294)
  code and test (Azure#23273)
  [textanalytics] release prep + fixing docstrings and links (Azure#23315)
  [Schema Registry] rename request kwargs to request options (Azure#23325)
  update new app service api version (Azure#23034)
  [SchemaRegistry] add tests for error codes (Azure#23140)
  Increment package version after release of azure-core (Azure#23319)
  Sync eng/common directory with azure-sdk-tools for PR 2824 (Azure#23314)
  Add python credscan in ci.yml (Azure#23307)
  [SchemaRegistry] avro api changes (Azure#23259)
  [KeyVualt KV] Fix cspell errors (Azure#23255)
  [KeyVault Certs] Fix cspell errors (Azure#23251)
  [AutoRelease] t2-containerregistry-2022-02-21-89653(Do not merge) (Azure#23155)
  [KeyVault Keys] Fix cspell errors (Azure#23250)
  Sync eng/common directory with azure-sdk-tools for PR 2830 (Azure#23267)
  ...
@adancarrasco adancarrasco mentioned this pull request Mar 8, 2022
Closed
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
@xiangyan99 @chlowell @rakshith91
update new app service api version (Azure#23034)
d0109bc 
* update new app service api version

* update

* update

* Add azure ml credential

* remove unused code

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* update

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@xiangyan99 @chlowell @rakshith91
update new app service api version (Azure#23034)
62854cc 
* update new app service api version

* update

* update

* Add azure ml credential

* remove unused code

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* Update sdk/identity/azure-identity/tests/test_managed_identity.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>

* update

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@mccoyp mccoyp Awaiting requested review from mccoyp

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangyan99 @chlowell