Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference tracing #31160

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

inference tracing #31160

wants to merge 5 commits into from

Conversation

howieleung
Copy link

@howieleung howieleung commented Sep 19, 2024 •
edited
Loading

Packages impacted by this PR

ai-inference

Issues associated with this PR

Describe the problem that is addressed by this PR

  • Added instrumentation to the inference client library.
  • Created generated folder that contains the generated code after linting and formatting.
  • lint and format are missing in the package.json. Added it. And apply lint and format fixed all errors within the inference library included the code I didn't touch.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes. added the test and recording.

Provide a list of related PRs (if any)

Nothing

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added Azure.Core OpenTelemetryInstrumentation test-utils Label for the issues related to the @azure/test-utils package labels Sep 19, 2024
maorleger
maorleger reviewed Sep 19, 2024
View reviewed changes
sdk/core/core-client-rest/src/getClient.ts Outdated Show resolved Hide resolved
sdk/core/core-tracing/review/core-tracing.api.md Outdated Show resolved Hide resolved
sdk/core/core-tracing/src/interfaces.ts Outdated Show resolved Hide resolved
sdk/instrumentation/opentelemetry-instrumentation-azure-sdk/src/spanWrapper.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingPolicy.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingPolicy.ts Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 19, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@howieleung howieleung marked this pull request as ready for review September 19, 2024 22:24
@howieleung howieleung force-pushed the howie/pipleline-policy-tracing branch 3 times, most recently from 4f0b161 to c162981 Compare September 20, 2024 20:27
@howieleung howieleung enabled auto-merge (squash) September 20, 2024 21:29
lmolkova
lmolkova approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but tracing-related changes LGTM overall!

sdk/ai/ai-inference-rest/src/tracingPolicy.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Show resolved Hide resolved
maorleger
maorleger approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks for working with us here, and I appreciate your thorough end-to-end validation 👍

sdk/ai/ai-inference-rest/package.json Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/package.json Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/constants.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Outdated Show resolved Hide resolved
sdk/ai/ai-inference-rest/src/tracingHelper.ts Outdated Show resolved Hide resolved
@lmolkova lmolkova mentioned this pull request Sep 24, 2024
Open
@maorleger maorleger mentioned this pull request Sep 24, 2024
Open
@howieleung howieleung mentioned this pull request Sep 24, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maorleger maorleger maorleger approved these changes

@lmolkova lmolkova lmolkova approved these changes

@glharper glharper glharper left review comments

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@bterlson bterlson Awaiting requested review from bterlson

@dargilco dargilco Awaiting requested review from dargilco dargilco is a code owner

@jhakulin jhakulin Awaiting requested review from jhakulin jhakulin is a code owner

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@timovv timovv Awaiting requested review from timovv

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki

@joheredi joheredi Awaiting requested review from joheredi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure.Core OpenTelemetryInstrumentation test-utils Label for the issues related to the @azure/test-utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@howieleung @azure-sdk @maorleger @lmolkova @glharper