Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage-queue] Migrate to core-rest-pipeline #26207

Merged
merged 8 commits into from
Jun 15, 2023

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Jun 14, 2023

Packages impacted by this PR

@azure/storage-queue

Issues associated with this PR

Fixes #15813
Closes #15594

Describe the problem that is addressed by this PR

This PR migrates storage-queue to the new core pipeline in the same way that storage-file-share was migrated. There are no changes to the public surface and existing recorded tests still pass.

Provide a list of related PRs (if any)

#26102

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jun 14, 2023
@xirzec xirzec self-assigned this Jun 14, 2023
@xirzec xirzec mentioned this pull request Jun 14, 2023
3 tasks
"@azure/logger": "^1.0.0",
"tslib": "^2.2.0"
"tslib": "^2.2.0",
"uuid": "^8.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: migrate to use core-util's randomUUID?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might do all of the storage packages at once in a follow-up PR, it's a good idea though!

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-queue

@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

export const SDK_VERSION: string = "12.12.0";
export const SDK_VERSION: string = "12.20.0";
export const SERVICE_VERSION: string = "2021-10-04";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really that old?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just had pushed all of the storage packages in main to 20 to not conflict with the stable branch until we were ready to release out of main again. We can bump these back down as needed. There's some catch up work before we can wind down stable that Jeremy is tracking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I wasn't clear, I meant to refer to L5 that has the service version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! Yeah, the queue service hasn't really been changed in a long time, it's mostly on life support is my understanding.

@xirzec
Copy link
Member Author

xirzec commented Jun 14, 2023

/azp run js - storage-queue - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xirzec
Copy link
Member Author

xirzec commented Jun 15, 2023

Looks like I might have to make storage-blob a devdep to clear up the pipeline issues

@xirzec
Copy link
Member Author

xirzec commented Jun 15, 2023

/azp run js - storage-queue - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xirzec xirzec merged commit 6582843 into Azure:main Jun 15, 2023
@xirzec xirzec deleted the storage-queue-v2 branch June 15, 2023 21:11
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Oct 16, 2023
Update readme.python.md (Azure#26207)

* Update readme.python.md

* Update readme.python.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
3 participants