Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core http compat to AI Metrics Advisor #20918

Merged

Conversation

JonathanCrd
Copy link
Member

Packages impacted by this PR

@azure/ai-metrics-advisor

Issues associated with this PR

Describe the problem that is addressed by this PR

AI Metrics Advisor has already migrated to the new Core client and Core rest pipeline libraries, however, this introduced too many breaking changes. In order to minimize the braking changes, core-http-compat was created. This PR regenerates the client with the latest version of autorest, with the core-http-compat-mode flag set to true, and no longer depending on core-http.

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@JonathanCrd JonathanCrd self-assigned this Mar 17, 2022
@JonathanCrd JonathanCrd changed the title Add http compat to metrics advisor Add core http compat to AI Metrics Advisor Mar 17, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/ai-metrics-advisor. You can review API changes here

API changes

- export interface MetricsAdvisorAdministrationClientOptions extends CommonClientOptions { }
+ export interface MetricsAdvisorAdministrationClientOptions extends ExtendedCommonClientOptions { }
- export interface MetricsAdvisorClientOptions extends CommonClientOptions { }
+ export interface MetricsAdvisorClientOptions extends ExtendedCommonClientOptions { }

@JonathanCrd JonathanCrd merged commit b4981b5 into Azure:main Mar 30, 2022
@JonathanCrd JonathanCrd deleted the Add-Http-Compat-to-Metrics-Advisor branch June 17, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants