Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Move one Key Vault package to use core-rest-pipeline #15522

Closed
sadasant opened this issue Jun 2, 2021 · 3 comments · Fixed by #15881
Closed

[Key Vault] Move one Key Vault package to use core-rest-pipeline #15522

sadasant opened this issue Jun 2, 2021 · 3 comments · Fixed by #15881
Assignees
@maorleger
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] July

Comments

@sadasant
Copy link
Contributor

sadasant commented Jun 2, 2021

This issue is to track moving all of the 4 Key Vault packages to use core-rest-pipeline.

Maor and I should be able to divide and conquer.

We’ll add more details over the following weeks.

I’m making this “blocking-release” since core-rest-pipelines is counting on this to confirm the public API shape is good for Key Vault.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault blocking-release Blocks release labels Jun 2, 2021
@sadasant sadasant added this to the [2021] July milestone Jun 2, 2021
@sadasant sadasant mentioned this issue Jun 2, 2021
Closed
@ramya-rao-a
Copy link
Contributor

Isnt this already covered in #14305?

@sadasant sadasant mentioned this issue Jun 7, 2021
Closed
@sadasant
Copy link
Contributor Author

sadasant commented Jun 7, 2021

@ramya-rao-a that is correct! I’ve closed: #15522 since I prefer how this one is phrased, and the description.

This was referenced Jun 7, 2021
Closed
Closed
@maorleger
Copy link
Member

maorleger commented Jun 8, 2021 •
edited
Loading

For July we're only moving one (other 3 are stretch depending on how that goes) - I will update this issue and create a separate issue for the other KV packages.

@sadasant sadasant removed their assignment Jun 15, 2021
@maorleger maorleger changed the title [Key Vault] Move the Key Vault packages to use core-rest-pipeline [Key Vault] Move one Key Vault package to use core-rest-pipeline Jun 22, 2021
This was referenced Jun 22, 2021
Merged
Closed
maorleger added a commit that referenced this issue Jun 23, 2021
@maorleger
[KeyVault] - Migrate Key Vault Admin package to Core V2 (#15881)
b499bfb 
## What

- Migrate @azure/keyvault-admin to core V2
- Migrate `KeyVaultBackupClient` and `KeyVaultAccessControlClient` to core CAE
- Bump our minimum `@azure/core-lro` version to 1.0.6

## Why

This PR proves out two important things: it demonstrates that core continuous access evaluation works for both container 
registry (already done) and Key Vault (this PR). It also demonstrates the migration path for Core V2 for Key Vault.

The change to core-lro addresses an issue where core-lro was incorrectly depending on core-http (#15880)  That has been fixed on 1.0.6 
and allows package owners to migrate to core-rest-pipeline and remove core-http without seeing build breaks.


Resolves #15522 
Resolves #14306
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[KeyVault] - Migrate Key Vault Admin package to Core V2 maorleger/azure-sdk-for-js
3 participants
@sadasant @maorleger @ramya-rao-a