Skip to content

Commit

Permalink
[Git precommit hook] Deleted (#13982)
Browse files Browse the repository at this point in the history
This PR deletes the git precommit hook after folks complained about it. I am keeping the rush prettier command in case anyone wants to keep the hook locally. 

I will merge this PR after I add a step for formatting checking in CI.
  • Loading branch information
deyaaeldeen authored Mar 16, 2021
1 parent e28dc30 commit 3f72e22
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 23 deletions.
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ To maintain the quality of the documentation, the following two facilities are p

TSDoc specifications can be customized using the `tsdoc.json` configuration file that can be found in the root of the repository. Currently, the `@hidden` tag is used which is only supported by TypeDoc and is not a TSDoc tag, so it is added as a custom tag in `tsdoc.json`.

### Formatting changed files

We used to have a git hook that formats your changed files on commit but it was removed because it did not work well for some people for various reasons. If you would like to enable it in your fork, you will need to just revert this [PR](https://github.com/Azure/azure-sdk-for-js/pull/13982/) in your branch and then run `rush update` so the hook script gets copied into `.git/hooks`. Moreover, without the hook, you can manually format changed files by invoking `rush prettier`.

## Onboarding a new library

All libraries must follow our [repository structure](https://github.com/Azure/azure-sdk/blob/master/docs/policies/repostructure.md) (specifically, it must be located at `sdk/<servicename>/<packagename>`) and your library's `package.json` must contain the required scripts as documented [above](#other-npm-scripts).
Expand Down
23 changes: 0 additions & 23 deletions common/git-hooks/pre-commit

This file was deleted.

0 comments on commit 3f72e22

Please sign in to comment.