Update links to point to a feature branch #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
requested review from
ahsonkhan,
gearama,
RickWinter and
vhvb1989
as code owners
ahsonkhan
reviewed
Nov 9, 2021
ahsonkhan
approved these changes
Nov 9, 2021
antkmsft
commented
Nov 9, 2021
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
ahsonkhan
reviewed
Nov 9, 2021
Comment on lines
-55
to
-59
| [BLOB_SDK_README]: https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage | ||
| [SDK_README_CONTRIBUTING]:https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage#contributing | ||
| [SDK_README_GETTING_STARTED]: https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage#getting-started | ||
| [SDK_README_KEY_CONCEPTS]: https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage#key-concepts | ||
| [samples_basic]: https://github.com/Azure/azure-sdk-for-c/blob/main/sdk/samples/storage/blobs/src/blobs_client_sample.c |
There was a problem hiding this comment.
Interesting that the failed leg only detected two invalid links, when there were some more:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1187023&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=617ceecd-bf48-5ce3-83e2-7468b1632a13
'file:///D:/a/_work/1/s/sdk/samples/storage/blobs/README.md' has 2 broken link(s):
https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage
https://github.com/Azure/azure-sdk-for-c/blob/main/sdk/samples/storage/blobs/src/blobs_client_sample.c
ahsonkhan
reviewed
Nov 10, 2021
| @@ -52,11 +52,11 @@ Azure SDK for Embedded C is licensed under the [MIT][azure_sdk_for_c_license] li | |||
| <!-- LINKS --> | |||
| [azure_sdk_for_c_contributing]: https://github.com/Azure/azure-sdk-for-c/blob/main/CONTRIBUTING.md | |||
| [azure_sdk_for_c_license]: https://github.com/Azure/azure-sdk-for-c/blob/main/LICENSE | |||
| [BLOB_SDK_README]: https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage | |||
| [SDK_README_CONTRIBUTING]:https://github.com/Azure/azure-sdk-for-c/tree/main/sdk/docs/storage#contributing | |||
There was a problem hiding this comment.
Btw, this link is not being referenced anywhere in the markdown and can be remove (unrelated cleanup, we can do later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.