Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6] Use CodeModel language metadata for Client Name #675

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[v6] Use CodeModel language metadata for Client Name #675

merged 1 commit into from
Jun 23, 2020

Conversation

joheredi
Copy link
Member

Instead of using codeModel.info.title use language metadata to leverage M4 pre-namer.

Fixes #673 which is caused by info.title containing () and not correctly normalizing for use as ClassName.

@joheredi joheredi requested a review from chradek June 23, 2020 20:52
@joheredi joheredi requested a review from daviwil as a code owner June 23, 2020 20:52
@joheredi joheredi merged commit 37f744b into Azure:v6 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

@chradek chradek chradek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joheredi @daviwil @chradek