Treat v11 as stable #218
Merged
Treat v11 as stable #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Jul 9, 2023
| <!--#if (AvaloniaStableChosen) --> | ||
| <!--#if (!AvaloniaStableChosen) --> |
There was a problem hiding this comment.
Feels like "stable" is not a valid term here, as both version are stable at this point. Some kind of enum property or multiple bool properties for each version might work better.
There was a problem hiding this comment.
I discussed with @Takoooooo about this and suggested "UseCurrentVersion", he meant "lets leave AvaloniaStableChosen,change it to AvaloniaVersion == "11.0.0" and negate expressions where it was used".
But agree enum like would be the easiest to maintain, as it would not change meaning anymore. Something like "IsV11" and "IsV0_10"?
There was a problem hiding this comment.
"IsV10" should be fine too :)
But yes, we can keep it out of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes that v11 is the one treated with AvaloniaStableChoosen, moves the "Latest stable" description form 0.10 to 11.0.
It also removes the ProjectCapability setting for 0.10 as it is now set there too: https://github.com/AvaloniaUI/Avalonia/blob/release/0.10.21/packages/Avalonia/Avalonia.props