Fix unpredictable choice between methods when using method binding. #8905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopper
reviewed
Sep 8, 2022
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Sep 8, 2022
…hen-using-method-binding
maxkatz6
deleted the
fix-unpredictable-choice-between-methods-when-using-method-binding
branch
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The idea is to only allow the usage in method bindings of methods without any parameters or methods with the parameter type of object. It is possible to decide which overload will be called at runtime but it will cause performance penalties which we want to avoid, currently, we find the correct method in the compile time which is obviously faster.
The complete idea is described by @grokys in this comment.
Breaking changes
This PR will introduce breaking changes in user code because currently we chose the first method in class that has the same name as in the binding. After this PR we chose the method with the parameter of type "object" first,then method without parameters.
Fixed issues
Fixes #5076