Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api diff #4348

Merged
merged 29 commits into from
Jul 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2514f62
begin adding api diff.
danwalmsley Jul 22, 2020
5498914
api diff on all projects.
danwalmsley Jul 22, 2020
ffb4d53
add api diff for avalonia.base
danwalmsley Jul 22, 2020
3b79d92
add properties for api diff versions and package locations.
danwalmsley Jul 22, 2020
26d68e9
add api diff to most projects.
danwalmsley Jul 22, 2020
54caeec
Merge branch 'master' into api-diff
danwalmsley Jul 22, 2020
4e5662c
fix builds
danwalmsley Jul 22, 2020
c859e8b
add baselines.
danwalmsley Jul 22, 2020
c4f1ed0
fix diff build.
danwalmsley Jul 22, 2020
77b47f6
fix linux build
danwalmsley Jul 22, 2020
d76047e
dont diff implementations / backends.
danwalmsley Jul 22, 2020
462c081
api compat baseline for visuals.
danwalmsley Jul 22, 2020
2892dcf
use targetframework var.
danwalmsley Jul 22, 2020
e75d17f
fix diff of Avalonia.Remote.Protocol.
danwalmsley Jul 22, 2020
b579058
download more packages for diffs.
danwalmsley Jul 22, 2020
53b7799
download datagrid for apidiff.
danwalmsley Jul 22, 2020
d480e93
download avalonia.diagnostics for api diff.
danwalmsley Jul 22, 2020
84c217f
pre-download avalonia.reactiveui for api diff.
danwalmsley Jul 22, 2020
793fa0d
pre-download avalonia.win32 for diff.
danwalmsley Jul 22, 2020
841a33b
package download with variable.
danwalmsley Jul 22, 2020
ac3ebbc
Merge branch 'master' into api-diff
danwalmsley Jul 23, 2020
fd817c0
add baselines.
danwalmsley Jul 23, 2020
7b3329c
add api attributes.
danwalmsley Jul 23, 2020
c1e8aa9
upgrade apicompat.
danwalmsley Jul 23, 2020
451ee7c
Revert "add baselines."
danwalmsley Jul 23, 2020
7d92a51
add baselines.
danwalmsley Jul 23, 2020
a01115f
Merge remote-tracking branch 'origin/master' into api-diff
danwalmsley Jul 23, 2020
3826b2f
Revert "add api attributes."
danwalmsley Jul 23, 2020
33dde5a
Merge branch 'master' into api-diff
danwalmsley Jul 24, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Avalonia.sln
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Props", "Props", "{F3AC8BC1
build\System.Memory.props = build\System.Memory.props
build\UnitTests.NetFX.props = build\UnitTests.NetFX.props
build\XUnit.props = build\XUnit.props
build\ApiDiff.props = build\ApiDiff.props
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Targets", "Targets", "{4D6FAF79-58B4-482F-9122-0668C346364C}"
Expand Down
2 changes: 2 additions & 0 deletions NuGet.Config
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>

<configuration>
<packageSources>
<clear />
<add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
</packageSources>
</configuration>
12 changes: 12 additions & 0 deletions build/ApiDiff.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<ApiContractPackageVersion>0.10.0-preview1</ApiContractPackageVersion>
<NugetPackageName Condition="'$(PackageId)' != ''">$(PackageId)</NugetPackageName>
<NugetPackageName Condition="'$(PackageId)' == ''">Avalonia</NugetPackageName>
</PropertyGroup>
<ItemGroup>
<PackageDownload Include="$(NugetPackageName)" Version="[$(ApiContractPackageVersion)]" />
<PackageReference Include="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.20372.2" PrivateAssets="All" />
<ResolvedMatchingContract Include="$(NuGetPackageRoot)\$(NugetPackageName.ToLower())\$(ApiContractPackageVersion)\lib\$(TargetFramework)\$(AssemblyName).dll" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Animation/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
3 changes: 2 additions & 1 deletion src/Avalonia.Animation/Avalonia.Animation.csproj
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Avalonia.Base\Avalonia.Base.csproj" />
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
3 changes: 3 additions & 0 deletions src/Avalonia.Base/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Compat issues with assembly Avalonia.Base:
MembersMustExist : Member 'public void Avalonia.Threading.AvaloniaSynchronizationContext..ctor()' does not exist in the implementation but it does exist in the contract.
Total Issues: 1
3 changes: 2 additions & 1 deletion src/Avalonia.Base/Avalonia.Base.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Avalonia.Base</AssemblyName>
<RootNamespace>Avalonia</RootNamespace>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Avalonia.Build.Tasks\Avalonia.Build.Tasks.csproj"/>
Expand All @@ -13,4 +13,5 @@
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\JetBrains.Annotations.props" />
<Import Project="..\..\build\System.Memory.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Controls.DataGrid/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@
<Import Project="..\..\build\EmbedXaml.props" />
<Import Project="..\..\build\JetBrains.Annotations.props" />
<Import Project="..\..\build\BuildTargets.targets" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
20 changes: 20 additions & 0 deletions src/Avalonia.Controls/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Compat issues with assembly Avalonia.Controls:
MembersMustExist : Member 'public Avalonia.Controls.TextBlock Avalonia.Controls.TextBlock Avalonia.Controls.TimePicker._periodText' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Controls.Chrome.TitleBar..ctor(Avalonia.Controls.Window)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Controls.Chrome.TitleBar.Attach()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Controls.Chrome.TitleBar.Detach()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Double Avalonia.Controls.Embedding.Offscreen.OffscreenTopLevelImplBase.Scaling.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Controls.Embedding.Offscreen.OffscreenTopLevelImplBase.Scaling.set(System.Double)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public Avalonia.Controls.Primitives.ChromeOverlayLayer Avalonia.Controls.Primitives.ChromeOverlayLayer.GetOverlayLayer(Avalonia.VisualTree.IVisual)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Boolean Avalonia.Controls.Templates.FuncDataTemplate.SupportsRecycling.get()' does not exist in the implementation but it does exist in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Boolean Avalonia.Controls.Templates.IDataTemplate.SupportsRecycling' is present in the contract but not in the implementation.
InterfacesShouldHaveSameMembers : Interface member 'public System.Boolean Avalonia.Controls.Templates.IDataTemplate.SupportsRecycling.get()' is present in the contract but not in the implementation.
MembersMustExist : Member 'public System.Boolean Avalonia.Controls.Templates.IDataTemplate.SupportsRecycling.get()' does not exist in the implementation but it does exist in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.ITopLevelImpl.RenderScaling' is present in the implementation but not in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.ITopLevelImpl.Scaling' is present in the contract but not in the implementation.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.ITopLevelImpl.RenderScaling.get()' is present in the implementation but not in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.ITopLevelImpl.Scaling.get()' is present in the contract but not in the implementation.
MembersMustExist : Member 'public System.Double Avalonia.Platform.ITopLevelImpl.Scaling.get()' does not exist in the implementation but it does exist in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.IWindowBaseImpl.DesktopScaling' is present in the implementation but not in the contract.
InterfacesShouldHaveSameMembers : Interface member 'public System.Double Avalonia.Platform.IWindowBaseImpl.DesktopScaling.get()' is present in the implementation but not in the contract.
Total Issues: 18
3 changes: 2 additions & 1 deletion src/Avalonia.Controls/Avalonia.Controls.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Avalonia.Animation\Avalonia.Animation.csproj" />
Expand All @@ -14,4 +14,5 @@
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\JetBrains.Annotations.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.DesignerSupport/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
2 changes: 2 additions & 0 deletions src/Avalonia.DesignerSupport/Avalonia.DesignerSupport.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<Version>0.7.0</Version>
<NoWarn>CS1591</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<NugetPackageName>Avalonia</NugetPackageName>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="Remote\HtmlTransport\webapp\build\**\*.gz" />
Expand All @@ -26,4 +27,5 @@
<ProjectReference Include="..\Avalonia.Themes.Default\Avalonia.Themes.Default.csproj" />
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Desktop/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
2 changes: 2 additions & 0 deletions src/Avalonia.Desktop/Avalonia.Desktop.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,6 @@
<ProjectReference Include="../../packages/Avalonia/Avalonia.csproj" />
<ProjectReference Include="../Avalonia.X11/Avalonia.X11.csproj" />
</ItemGroup>

<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.DesktopRuntime/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.DesktopRuntime/Avalonia.DesktopRuntime.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
<Import Project="..\..\build\NetCore.props" />
<Import Project="..\..\build\NetFX.props" />
<Import Project="..\Shared\PlatformSupport\PlatformSupport.projitems" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Diagnostics/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
2 changes: 2 additions & 0 deletions src/Avalonia.Diagnostics/Avalonia.Diagnostics.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>Avalonia</RootNamespace>
<PackageId>Avalonia.Diagnostics</PackageId>
</PropertyGroup>
<ItemGroup>
<Compile Update="**\*.xaml.cs">
Expand All @@ -28,4 +29,5 @@
<Import Project="..\..\build\EmbedXaml.props" />
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\BuildTargets.targets" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Dialogs/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
2 changes: 2 additions & 0 deletions src/Avalonia.Dialogs/Avalonia.Dialogs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@
<ItemGroup>
<ProjectReference Include="..\Markup\Avalonia.Markup.Xaml\Avalonia.Markup.Xaml.csproj" />
</ItemGroup>

<Import Project="..\..\build\ApiDiff.props" />
</Project>
5 changes: 2 additions & 3 deletions src/Avalonia.FreeDesktop/Avalonia.FreeDesktop.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand All @@ -10,6 +10,5 @@

<ItemGroup>
<PackageReference Include="Tmds.DBus" Version="0.7.0" />
</ItemGroup>

</ItemGroup>
</Project>
3 changes: 2 additions & 1 deletion src/Avalonia.Headless/Avalonia.Headless.csproj
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>

</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\packages\Avalonia\Avalonia.csproj" />
</ItemGroup>
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Input/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Input/Avalonia.Input.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@
<ProjectReference Include="..\Avalonia.Visuals\Avalonia.Visuals.csproj" />
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Interactivity/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Interactivity/Avalonia.Interactivity.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
<ProjectReference Include="..\Avalonia.Visuals\Avalonia.Visuals.csproj" />
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Layout/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Layout/Avalonia.Layout.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
<ProjectReference Include="..\Avalonia.Visuals\Avalonia.Visuals.csproj" />
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.OpenGL/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.OpenGL/Avalonia.OpenGL.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
<ProjectReference Include="..\Avalonia.Visuals\Avalonia.Visuals.csproj" />
</ItemGroup>

<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.ReactiveUI/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.ReactiveUI/Avalonia.ReactiveUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ReactiveUI.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Remote.Protocol/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
2 changes: 2 additions & 0 deletions src/Avalonia.Remote.Protocol/Avalonia.Remote.Protocol.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
<DefineConstants>AVALONIA_REMOTE_PROTOCOL;$(DefineConstants)</DefineConstants>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>Key.snk</AssemblyOriginatorKeyFile>
<PackageId>Avalonia.Remote.Protocol</PackageId>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\Avalonia.Input\Key.cs" />
</ItemGroup>
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Styling/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Styling/Avalonia.Styling.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
<ProjectReference Include="..\Avalonia.Animation\Avalonia.Animation.csproj" />
<ProjectReference Include="..\Avalonia.Base\Avalonia.Base.csproj" />
</ItemGroup>
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Themes.Default/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Themes.Default/Avalonia.Themes.Default.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@
</ItemGroup>
<Import Project="..\..\build\BuildTargets.targets" />
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Avalonia.Themes.Fluent/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Avalonia.Themes.Fluent/Avalonia.Themes.Fluent.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
</ItemGroup>
<Import Project="..\..\build\BuildTargets.targets" />
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
12 changes: 12 additions & 0 deletions src/Avalonia.Visuals/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Compat issues with assembly Avalonia.Visuals:
EnumValuesMustMatch : Enum value 'Avalonia.Media.TextWrapping Avalonia.Media.TextWrapping.NoWrap' is (System.Int32)0 in the implementation but (System.Int32)1 in the contract.
EnumValuesMustMatch : Enum value 'Avalonia.Media.TextWrapping Avalonia.Media.TextWrapping.Wrap' is (System.Int32)1 in the implementation but (System.Int32)2 in the contract.
EnumValuesMustMatch : Enum value 'Avalonia.Media.TextWrapping Avalonia.Media.TextWrapping.WrapWithOverflow' is (System.Int32)2 in the implementation but (System.Int32)0 in the contract.
MembersMustExist : Member 'public void Avalonia.Media.TextFormatting.GenericTextParagraphProperties..ctor(Avalonia.Media.TextFormatting.TextRunProperties, Avalonia.Media.TextAlignment, Avalonia.Media.TextWrapping, Avalonia.Media.TextTrimming, System.Double)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public Avalonia.Media.TextTrimming Avalonia.Media.TextFormatting.GenericTextParagraphProperties.TextTrimming.get()' does not exist in the implementation but it does exist in the contract.
CannotAddAbstractMembers : Member 'public System.Boolean Avalonia.Media.TextFormatting.TextLine.HasCollapsed' is abstract in the implementation but is missing in the contract.
CannotAddAbstractMembers : Member 'public Avalonia.Media.TextFormatting.TextLine Avalonia.Media.TextFormatting.TextLine.Collapse(Avalonia.Media.TextFormatting.TextCollapsingProperties[])' is abstract in the implementation but is missing in the contract.
CannotAddAbstractMembers : Member 'public System.Boolean Avalonia.Media.TextFormatting.TextLine.HasCollapsed.get()' is abstract in the implementation but is missing in the contract.
MembersMustExist : Member 'public void Avalonia.Media.TextFormatting.TextLineMetrics..ctor(Avalonia.Size, System.Double, Avalonia.Media.TextFormatting.TextRange)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public Avalonia.Media.TextTrimming Avalonia.Media.TextFormatting.TextParagraphProperties.TextTrimming.get()' does not exist in the implementation but it does exist in the contract.
danwalmsley marked this conversation as resolved.
Show resolved Hide resolved
Total Issues: 10
1 change: 1 addition & 0 deletions src/Avalonia.Visuals/Avalonia.Visuals.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@
</ItemGroup>
<Import Project="..\..\build\Rx.props" />
<Import Project="..\..\build\System.Memory.props" />
<Import Project="..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Linux/Avalonia.LinuxFramebuffer/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
<ItemGroup>
<ProjectReference Include="..\..\..\packages\Avalonia\Avalonia.csproj" />
<ProjectReference Include="..\..\Skia\Avalonia.Skia\Avalonia.Skia.csproj" />
</ItemGroup>
</ItemGroup>
<Import Project="..\..\..\build\ApiDiff.props" />
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IsPackable>true</IsPackable>
<PackageId>Avalonia.Markup.Xaml.Loader</PackageId>
</PropertyGroup>
<Import Project="IncludeXamlIlSre.props" />
<ItemGroup>
<PackageReference Include="System.Reflection.Emit" Version="4.3.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Avalonia.Markup.Xaml\Avalonia.Markup.Xaml.csproj" />
</ItemGroup>
</ItemGroup>
</Project>
15 changes: 15 additions & 0 deletions src/Markup/Avalonia.Markup.Xaml/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Compat issues with assembly Avalonia.Markup.Xaml:
CannotMakeTypeAbstract : Type 'Avalonia.Markup.Xaml.AvaloniaXamlLoader' is abstract in the implementation but is not abstract in the contract.
CannotSealType : Type 'Avalonia.Markup.Xaml.AvaloniaXamlLoader' is actually (has the sealed modifier) sealed in the implementation but not sealed in the contract.
MembersMustExist : Member 'public void Avalonia.Markup.Xaml.AvaloniaXamlLoader..ctor()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Boolean Avalonia.Markup.Xaml.AvaloniaXamlLoader.IsDesignMode.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Markup.Xaml.AvaloniaXamlLoader.IsDesignMode.set(System.Boolean)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Object Avalonia.Markup.Xaml.AvaloniaXamlLoader.Load(System.IO.Stream, System.Reflection.Assembly, System.Object, System.Uri)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Object Avalonia.Markup.Xaml.AvaloniaXamlLoader.Load(System.String, System.Reflection.Assembly, System.Object)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Object Avalonia.Markup.Xaml.AvaloniaXamlLoader.Parse(System.String, System.Reflection.Assembly)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public T Avalonia.Markup.Xaml.AvaloniaXamlLoader.Parse<T>(System.String, System.Reflection.Assembly)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Boolean Avalonia.Markup.Xaml.Templates.DataTemplate.SupportsRecycling.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Markup.Xaml.Templates.DataTemplate.SupportsRecycling.set(System.Boolean)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public System.Boolean Avalonia.Markup.Xaml.Templates.TreeDataTemplate.SupportsRecycling.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'public void Avalonia.Markup.Xaml.Templates.TreeDataTemplate.SupportsRecycling.set(System.Boolean)' does not exist in the implementation but it does exist in the contract.
Total Issues: 13
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,5 @@
<ProjectReference Include="..\Avalonia.Markup\Avalonia.Markup.csproj" />
</ItemGroup>
<Import Project="..\..\..\build\Rx.props" />
<Import Project="..\..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Markup/Avalonia.Markup/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Markup/Avalonia.Markup/Avalonia.Markup.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
</ItemGroup>
<Import Project="..\..\..\build\Rx.props" />
<Import Project="..\..\..\build\System.Memory.props" />
<Import Project="..\..\..\build\ApiDiff.props" />
</Project>
1 change: 1 addition & 0 deletions src/Skia/Avalonia.Skia/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Total Issues: 0
1 change: 1 addition & 0 deletions src/Skia/Avalonia.Skia/Avalonia.Skia.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
<Import Project="..\..\..\build\SkiaSharp.props" />
<Import Project="..\..\..\build\HarfBuzzSharp.props" />
<Import Project="..\..\Shared\RenderHelpers\RenderHelpers.projitems" Label="Shared" />
<Import Project="..\..\..\build\ApiDiff.props" />
</Project>
3 changes: 3 additions & 0 deletions src/Windows/Avalonia.Win32/ApiCompatBaseline.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Compat issues with assembly Avalonia.Win32:
MembersMustExist : Member 'public System.Double Avalonia.Win32.WindowImpl.Scaling.get()' does not exist in the implementation but it does exist in the contract.
Total Issues: 1
1 change: 1 addition & 0 deletions src/Windows/Avalonia.Win32/Avalonia.Win32.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
<PackageReference Include="Avalonia.Angle.Windows.Natives" Version="2.1.0.2019013001" />
</ItemGroup>
<Import Project="$(MSBuildThisFileDirectory)\..\..\..\build\System.Drawing.Common.props" />
<Import Project="..\..\..\build\ApiDiff.props" />
</Project>