Fix text rendering where TextAlignment != Left. #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The renderer was using the wrong bounds for text where `TextAlignment != Left` as seen in #1625. To fix this, change `FormattedTextImpl.Size` to `Bounds`, which returns a rect that takes into account the text alignment and similarly change `FormattedText.Measure` to return a `Rect` instead of a `Size. Fixes #1625.
Gillibald
reviewed
Mar 4, 2019
Changed `FormattedText.Measure` method to a `Bounds` property.
|
Going to merge this despite no approvals because @Gillibald has taken a look and it's been 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes rendering of
TextBlocks whereTextAlignment != Leftas described in #1625.What is the current behavior?
If
TextAlignment != Left, the bounds passed toTextNodedo not accurately reflect the bounds of the text to be drawn, causing changes to theTextBlockto not get rendered.What is the updated/expected behavior with this PR?
Non-left aligned text is updated correctly by the renderer.
How was the solution implemented (if it's not obvious)?
To use the correct bounds, this PR changes
FormattedTextImpl.SizetoBounds, which returns a rect that takes into account the text alignment and similarly changesFormattedText.Measureto a propertyBounds.Breaking changes
FormattedText.Measure()changed toBoundsproperty.Fixed issues
Fixes #1625
cc: @Gillibald