-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Items property to ItemsSource (non-ItemsControl) #10831
Conversation
I personally think the users would expect that if |
You can test this PR using the following package version. |
…com/AvaloniaUI/Avalonia into refactor/other-controls-itemssource
You can test this PR using the following package version. |
You can test this PR using the following package version. |
What does the pull request do?
Renames the
Items
property toItemsSource
on controls other thanItemsControl
(which was done in #10590). The following controls were converted:DataGrid
AutoCompleteBox
ItemsRepeater
MenuFlyout
- this one now has bothItems
andItemsSource
(from discussion with @maxkatz6 )For the controls which now have only an
ItemsSource
property, we could add anItems
property for compatibility but I've not done that here. Let me know if that would be a good idea.Breaking changes
The
Items
property onDataGrid
,AutoCompleteBox
andItemsRepeater
has been renamed toItemsSource
.The
Items
property onMenuFlyout
is now readonly -ItemsSource
should be used for setting/binding.Depends on #10827