Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Decouple | Expose Data Layer #1757

Merged
merged 22 commits into from
Sep 16, 2024

Conversation

dinhlongviolin1
Copy link
Member

Resolve Avaiga/taipy-designer#223

@dinhlongviolin1 dinhlongviolin1 changed the title template for Fred Decouple | Expose Data Layer Sep 7, 2024
@dinhlongviolin1 dinhlongviolin1 changed the title Decouple | Expose Data Layer Frontend Decouple | Expose Data Layer Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 68.63810741687979%

St.
Category Percentage Covered / Total
🟢 Statements
87.57% (-0.3% 🔻)
3176/3627
🟡 Branches
68.64% (-0.82% 🔻)
2147/3128
🟢 Functions
82.6% (-0.56% 🔻)
579/701
🟢 Lines
88.13% (-0.31% 🔻)
2940/3336
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
100% 91.3% 100% 100%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
83.93% 58.18% 75% 84.62%
🟢
... / Part.tsx
88.46% 68.75% 75% 91.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / Chart.tsx
59.62%
30.66% (-0.11% 🔻)
57.5% 59.68%

Test suite run success

608 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 4f1d11d

Copy link
Contributor

github-actions bot commented Sep 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19324 16263 84% 0% 🟢

New Files

File Coverage Status
taipy/gui/custom/utils.py 72% 🟢
TOTAL 72% 🟢

Modified Files

File Coverage Status
taipy/gui/custom/_page.py 58% 🟢
taipy/gui/data/pandas_data_accessor.py 79% 🟢
taipy/gui/gui.py 79% 🟢
taipy/gui/utils/_variable_directory.py 95% 🟢
TOTAL 78% 🟢

updated for commit: 4f1d11d by action🐍

@dinhlongviolin1 dinhlongviolin1 marked this pull request as ready for review September 13, 2024 06:33
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Sep 13, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

taipy/gui/gui.py Show resolved Hide resolved
taipy/gui/gui.py Outdated Show resolved Hide resolved
taipy/gui/custom/_page.py Show resolved Hide resolved
taipy/gui/gui.py Show resolved Hide resolved
taipy/gui/gui.py Outdated Show resolved Hide resolved
taipy/gui/gui.py Outdated Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

frontend/taipy-gui/base/src/app.ts Outdated Show resolved Hide resolved
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Sep 14, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

taipy/gui/custom/utils.py Show resolved Hide resolved
taipy/gui/custom/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Sep 16, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth 22 commits!!

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@dinhlongviolin1 dinhlongviolin1 merged commit 51694f5 into develop Sep 16, 2024
71 of 72 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the feature/decouple-data-layer branch September 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants