Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged-in Performance Profiler: Show jetpack boost upsell in recommendations #94691

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Sep 18, 2024

Closes https://github.com/Automattic/dotcom-forge/issues/9060

Proposed Changes

  • Show the jetpack boost tip for logged-in user based on the type of page issue.
    image

Why are these changes being made?

  • Provides a quick way for users to fix certain problems on their site using Jetpack Boost as an option.

Testing Instructions

  • As a logged in user
  • Use speed test tool /speed-test-tool to run test on your Wordpress Atomic site
  • Open the Properly size images improvement section and verify Jetpack Boost is recommended in the Did you know section

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Logged-in Performance Profiler i1 labels Sep 18, 2024
@vykes-mac vykes-mac self-assigned this Sep 18, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 18, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/show-boost-upsell on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~177 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
site-performance           +597 B  (+0.0%)     +177 B  (+0.0%)
performance-profiler       +597 B  (+0.2%)     +177 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac vykes-mac merged commit bc50354 into trunk Sep 18, 2024
15 checks passed
@vykes-mac vykes-mac deleted the update/show-boost-upsell branch September 18, 2024 22:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 18, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 19, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logged-in Performance Profiler i1 Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants