E2E: Fix click location in FullSiteEditorDataViewsComponent #89420
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to WordPress/gutenberg#59803, the `a` inside the `.dataviews-view-table__primary-field` div occupied the full width of the div, so when Playwright clicked in the center of the div it would hit the link. That PR changed things up a bit, now the `a` is not expanded to fill the entire div and a click in the middle of the div misses the link, meaning the test never navigates to the next page as expected. This updates the logic to click the actual `a` instead of the div.
anomiex
added
[Type] Bug
[Pri] Normal
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Prior to WordPress/gutenberg#59803, the
ainside the.dataviews-view-table__primary-fielddiv occupied the full width of the div, so when Playwright clicked in the center of the div it would hit the link.That PR changed things up a bit, now the
ais not expanded to fill the entire div and a click in the middle of the div misses the link, meaning the test never navigates to the next page as expected.This updates the logic to click the actual
ainstead of the div.Testing Instructions
Pre-merge Checklist