Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Onboarding: Fix CSS class names in signup route and fix cart display header #36432

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

justinshreve
Copy link
Contributor

Note that the flows affected in this PR are currently behind a feature flag while onboarding work is ongoing in WooCommerce Core. Please see 22a33-pb for designs of these flows.

Testing instructions

We are going to work on a test build of the onboarding code that will make testing things easier, but in the meantime the best way to load these is the following:

  • npm start this branch
  • Install WooCommerce
  • Install WooCommerce Admin from GitHub (https://github.com/woocommerce/woocommerce-admin) and npm run dev.
  • define( 'WOOCOMMERCE_CALYPSO_ENVIRONMENT', 'development' ); in your wp-config.php.
  • define( 'WP_DEBUG', true ); in your wp-config.php.
  • Go to /wp-admin/edit.php?post_type=shop_order and click the Help Tab.
  • Under Setup Wizard you should see Quickly access the WooCommerce.com connection flow in Calypso.. Click the connect button here.
  • Visually inspect the signup and login pages.
  • You can change wccom-from in the query string to wccom-from=cart to test the cart header display.

Screenshots

Screen Shot 2019-09-30 at 10 54 32 AM

Screen Shot 2019-09-30 at 10 54 42 AM

@justinshreve justinshreve added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 30, 2019
@justinshreve justinshreve requested a review from a team as a code owner September 30, 2019 15:23
@justinshreve justinshreve self-assigned this Sep 30, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~3 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user        +36 B  (+0.0%)       -3 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to CSS look good and this is testing well. I can see the login with existing account and create accounts flows, as well as each flow with the wccom-from variation.

Styles look good.

@justinshreve justinshreve added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 7, 2019
@justinshreve justinshreve merged commit 86a3892 into master Oct 7, 2019
@justinshreve justinshreve deleted the fix/woo-css-classes branch October 7, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants