Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: PR for e2e testing of Gutenberg v6.3.0 RC1 on Horizon. #35343

Closed
wants to merge 1 commit into from
Closed

Gutenberg: PR for e2e testing of Gutenberg v6.3.0 RC1 on Horizon. #35343

wants to merge 1 commit into from

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Aug 13, 2019

This PR is for running e2e tests on Horizon to test Gutenberg v6.3.0 RC1, and making any required test fixes.

@kwight kwight requested review from a team as code owners August 13, 2019 16:28
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=try/gutenberg630rc

@kwight kwight self-assigned this Aug 13, 2019
@kwight kwight added [Status] Needs e2e Testing horizon Run e2e tests against horizon env [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 13, 2019
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@kwight kwight mentioned this pull request Aug 13, 2019
Closed
7 tasks
@kwight
Copy link
Contributor Author

kwight commented Aug 13, 2019

Failures:
Screen Shot 2019-08-13 at 2 18 40 PM
Screen Shot 2019-08-13 at 2 19 00 PM

@kwight
Copy link
Contributor Author

kwight commented Aug 13, 2019

Timed out waiting for element with css selector of '.jetpack-simple-payments-wrapper' to be present and displayed coincides with feedback from p7DVsv-783-p2, and doesn't need adjustment here (likely a regression in Gutenberg core).

@kwight
Copy link
Contributor Author

kwight commented Aug 13, 2019

Not sure about .components-snackbar__content a; I have no problem producing it when manually updating a post.

@kwight kwight added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Aug 14, 2019
@kwight
Copy link
Contributor Author

kwight commented Aug 14, 2019

Latest results are based on running e2e tests after updating Horizon to the official 6.3.0 release from today.

Screen Shot 2019-08-14 at 3 35 44 PM

Screen Shot 2019-08-14 at 3 36 50 PM

Timed out waiting for element with css selector of 'input.components-form-token-field__input' to be present and displayed: I don't have any problem manually accomplishing this task; the markup seems correct.

@mmtr
Copy link
Member

mmtr commented Aug 15, 2019

I can reproduce the failure of the "Schedule Basic Public Post" test in a self-hosted site as well, when using Gutenberg 6.3.0:

Aug-15-2019 11-15-40

The issue is not reproducible on 6.2.0, so seems to be a regression. I filed an issue on the Gutenberg repo: WordPress/gutenberg#17042

@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Aug 15, 2019
@mmtr
Copy link
Member

mmtr commented Aug 15, 2019

Not sure about .components-snackbar__content a; I have no problem producing it when manually updating a post.

It might be caused by the snackbars being placed behind the inline help:

Screen Shot 2019-08-15 at 14 15 32

@mmtr
Copy link
Member

mmtr commented Aug 15, 2019

Not sure about .components-snackbar__content a; I have no problem producing it when manually updating a post.

It might be caused by the snackbars being placed behind the inline help

I verified the notices are also a bit misplaced when using the plugin on a self-hosted site, so it looks like another regression introduced by Gutenberg 6.3.0: WordPress/gutenberg#17045

Anyway, even with 6.2.0 the inline help hides part of the notices content, but it is visible enough to pass the E2E test.

Screen Shot 2019-08-15 at 15 42 11

Maybe we could adjust the position of the notices with an override in Gutenframe and make them totally visible, so we don't depend on a fix by Core.

@kwight
Copy link
Contributor Author

kwight commented Aug 15, 2019

We have enough regression issues that we've decided to wait for 6.4.0 (see paYKcK-bO-p2).

@kwight kwight closed this Aug 15, 2019
@kwight kwight deleted the try/gutenberg630rc branch August 15, 2019 19:53
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 15, 2019
@kwight kwight mentioned this pull request Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kwight kwight

Labels
[Status] Needs e2e Testing horizon Run e2e tests against horizon env
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwight @matticbot @mmtr