Tiled gallery block: limit the columns count to the images count #30582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
added
[Type] Bug
[Goal] Gutenberg
simison
commented
Feb 4, 2019
| max={ Math.min( MAX_COLUMNS, images.length ) } | ||
| /> | ||
| ) } | ||
| { layoutSupportsColumns( layoutStyle ) && images.length > 1 && ( |
There was a problem hiding this comment.
Unrelated Prettier changes.
sirreal
added
[Status] Needs Review
matticbot
removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the columns attribute when the
onSelectImagesfunction fires so that if images are removed via the media modal, the columns will be updated. This way columns won't be higher than the new number of images.Previously this worked if removing images via the X in the editor, but not if you removed them via the media modal.
Kudos for @brentswisher as this is basically their fix from upstream core gallery block: WordPress/gutenberg#13488
Fixes #30015
Changes proposed in this Pull Request
Testing instructions