Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty-Three Base Theme #6360

Closed
wants to merge 15 commits into from
Closed

Twenty Twenty-Three Base Theme #6360

wants to merge 15 commits into from

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Aug 9, 2022

Using this PR as a place to get TT3 into a ready state for the TT3 repo.

TT3 is a stripped-back version of TT2, so I believe the general layouts should be the same/similar, and the colours and fonts should be simple and easy to customise with style variations.

So far, this PR includes:

  • Clone of TT2, renamed to TT3
  • Remove TT2's patterns
  • Remove TT2's dark headers (but keep every other template part)
  • Add TT3's base colours
  • Add the 3 base fonts (System Font, DM Sans, and Source Serif Pro)
  • Add font and heading sizes, using fluid sizes where possible
  • Add spacing presets (WIP)
  • Add the 4 additional style variations (WIP)

From a reviewing perspective, it would be great if you could check:

  • Have I made the correct decisions with what to include and exclude from TT2? (especially with templates and patterns)
  • Fonts, colours, and spacing against @beafialho's designs
  • Proofread the README.md
  • Check that recently added GB features are included (I've made sure to include fluid typography and spacing presets)
  • And generally everything else 🙈 Or anything you see that doesn't look right!

@mikachan mikachan self-assigned this Aug 9, 2022
@beafialho
Copy link
Collaborator

A few comments on differences I spotted in TT2 and the base theme:

Typography

Seems slightly bolder than in TT2.

tt3

Links

TT3 Hover states:

tt3navlinks.mp4
tt3_links.mp4

TT2 (Intended hover states):

tt2navlinks.mp4
tt2_links.mp4

Text links should be #345C00 instead of #9DFF20

Buttons

Hover states don't seem to match the mockups.

button_hover.mp4

Captura de ecrã 2022-08-10, às 12 53 32

Spacing

There's more spacing in TT2's header.

TT2 (Intended) TT3
Captura de ecrã 2022-08-10, às 12 54 11 Captura de ecrã 2022-08-10, às 12 54 19

twentytwentythree/readme.txt Show resolved Hide resolved
twentytwentythree/readme.txt Show resolved Hide resolved
twentytwentythree/functions.php Show resolved Hide resolved
twentytwentythree/theme.json Show resolved Hide resolved
@mikachan
Copy link
Member Author

Thanks, Bea!

Typography: Seems slightly bolder than in TT2.

It looks like this is because TT2 applies the following CSS globally:

body {
	-moz-osx-font-smoothing: grayscale;
	-webkit-font-smoothing: antialiased;
}

Initially, I was trying to avoid using CSS at all, with no style.css or functions.php file. However, the font looks so much better with this font-smoothing setting...

TT3 Hover states vs TT2 (Intended hover states)

These should be done (with no CSS!)

Text links should be #345C00 instead of #9DFF20

Done.

Buttons: Hover states don't seem to match the mockups.

Sorry, I should've mentioned that the button hover states need this GB PR to work: WordPress/gutenberg#43088

Spacing: There's more spacing in TT2's header.

Working on this now...

@mikachan
Copy link
Member Author

Thanks all. Closing this and moving everything over to https://github.com/WordPress/twentytwentythree.

@mikachan mikachan closed this Aug 10, 2022
@mikachan mikachan deleted the try/twentytwentythree branch August 10, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants