Club: update typography styles #6255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Jul 18, 2022
|
Thank you so much @madhusudhand for working on this. I have been delaying the review of this PR because I wanted to read the discussion around fluid typography sizes on this recently merged PR. I guess we should leverage the fluid type sizes API in theme.json instead of recreating the formula. To test that implementation I submitted this PR as an alternative to this. |
madhusudhand
force-pushed
the
club/typography
branch
from
d242057
to
9836eb6
Compare
|
Closing this in favour of #6262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This addresses font-
sizeweightstyle,line-height,letter-spacingfor the following elements/blocksNote: for the fluid typography,
clampvalues are generated using https://websemantics.uk/tools/responsive-font-calculator/. It is the calculation implemented in WordPress/gutenberg#39529 with viewport limits between48remand100remPreview
Index page:
Single page: post title
Headings:
Paragraphs:
Related issue(s):
Fixes #6212 #6213