Skip to content

Commit

Permalink
fix: Avoid unnecessary sqlite-database-integration upgrades
Browse files Browse the repository at this point in the history
If version comparison fails, assume the installed version is the latest.
For example, fetching the latest version while offline will result in a
comparison failure.
  • Loading branch information
dcalhoun committed May 17, 2024
1 parent 847e40a commit 8afbeb0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/lib/sqlite-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ export async function isSqliteInstallationOutdated( installationPath: string ):
const installedVersion = getSqliteVersionFromInstallation( installationPath );
const latestVersion = await getLatestSqliteVersion();
return semver.lt( installedVersion, latestVersion );
} catch ( error ) {
Sentry.captureException( error );
return true;
} catch ( _error ) {
return false;
}
}

Expand Down

0 comments on commit 8afbeb0

Please sign in to comment.