-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't translate Sensei custom post types #6986
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #6986 +/- ##
============================================
- Coverage 46.73% 46.72% -0.01%
Complexity 10226 10226
============================================
Files 570 568 -2
Lines 36881 36865 -16
Branches 402 401 -1
============================================
- Hits 17236 17225 -11
+ Misses 19318 19314 -4
+ Partials 327 326 -1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Significance: patch | ||
Type: fixed | ||
|
||
Disable translation of Sensei post types, taxonomies and fields to temporary fix compatibilty issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider a different change log entry here, as this is likely to scare everyone with translated sites. It should mention that it's a compatibility fix for WPML.
@merkushin I'm a bit uncertain of the impact of this change. I think it means that users will not be able to create translations for courses and lessons at all? There was a time when Sensei content was able to be translated with WPML, so I'm a bit worried that we've just broken it somewhere along the way, and disabling it altogether may not be the best option. This would also disable it for those using the Classic Editor plugin, where I don't think translations are broken. So we'd be taking a possible workaround away by making this change. Maybe we should go ahead and try to solve as part of #2788? |
@donnapep Makes sense. In general, I am for solving the issue. This PR tried to solve the problem for new users who get upset because of unexpected issues. Personally for me, it is better to see a clear message that this feature doesn't work yet, then a message that it might work or not. And this PR appeared 'cause we didn't have a clear plan regarding ML, I mean we didn't know what exactly we want to do and when. Anyway, I'm glad to hear that now we have more dedication to solve the issue permanently. A small update:
I forgot to address this part. It is still possible to change WPML settings in WP Admin, so it just could be the default behavior. |
Resolves #6978
Our post types like Course and Lesson store additional information about related entities.
We can't allow WPML try to translate them automatically.
Here I disable translation to fix the bug with saving courses and lessons.
Later, we need to address the problem in our ML project.
I updated the list of custom post types, taxonomies and custom fields. I hope it might help us in the future.
As for fields, the list is not complete as we have auto-generated fields like
_order_module_17
.Proposed Changes
Testing Instructions
New/Updated Hooks
Deprecated Code
Pre-Merge Checklist