Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set e2e tests against WP 5.6 until 5.7 docker image fixed #4067

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Set e2e tests against WP 5.6 until 5.7 docker image fixed #4067

merged 1 commit into from
Mar 11, 2021

Conversation

jom
Copy link
Member

@jom jom commented Mar 11, 2021 •
edited
Loading

Changes proposed in this Pull Request

  • There appears to be an issue with WordPress 5.7's official docker image.

@jom jom marked this pull request as ready for review March 11, 2021 15:52
@jom jom self-assigned this Mar 11, 2021
@jom jom requested a review from a team March 11, 2021 15:52
gikaragia
gikaragia approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One task appears stuck.

@jom
Copy link
Member Author

jom commented Mar 11, 2021 •
edited
Loading

I put up a fix in @woocommerce/e2e-environment (woocommerce/woocommerce#29346), but we'll need to update ours a bit before we can update to the new version of @woocommerce/e2e-environment.

That test ran it just didn't report back. Force merging.

@jom jom merged commit 66cfecf into master Mar 11, 2021
@jom jom deleted the change/e2e-wp-target branch March 11, 2021 16:45
@swissspidy
Copy link

WordPress 5.7's official docker image.

FWIW this image is maintained by the Docker community, not WordPress. So not "official" in that sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

Assignees

@jom jom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jom @swissspidy @gikaragia @donnapep